Skip to content

Make CSINodeInfo and CSIDriver Core APIs#73883

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
xing-yang:csi_crd
Mar 5, 2019
Merged

Make CSINodeInfo and CSIDriver Core APIs#73883
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
xing-yang:csi_crd

Conversation

@xing-yang
Copy link
Copy Markdown
Contributor

@xing-yang xing-yang commented Feb 10, 2019 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR is the first step to transition CSINodeInfo and CSIDriver
CRD's to in-tree APIs. It adds them to the existing API group
“storage.k8s.io” as v1beta1 core storage APIs.

Which issue(s) this PR fixes:

Fixes #
kubernetes/enhancements#770
kubernetes/enhancements#603

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Transition CSINodeInfo and CSIDriver to in-tree core storage v1beta1 APIs.
The support for `_` in the CSI driver name will be dropped as the CSI Spec does not allow that.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 10, 2019
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 10, 2019
@xing-yang
Copy link
Copy Markdown
Contributor Author

xing-yang commented Feb 10, 2019

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Feb 10, 2019
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Feb 10, 2019
@xing-yang
Copy link
Copy Markdown
Contributor Author

xing-yang commented Feb 10, 2019

/test pull-kubernetes-verify

@msau42
Copy link
Copy Markdown
Member

msau42 commented Feb 11, 2019

/assign @msau42 @davidz627

gnufied
gnufied reviewed Feb 11, 2019
View reviewed changes
@davidz627
Copy link
Copy Markdown
Contributor

davidz627 commented Feb 11, 2019

@xing-yang could you seperate the PR out into two/three commits? One for API changes, one for generated code, one for any additional changes (if there are any).

This would make it much easier to review. Thanks!

@xing-yang
Copy link
Copy Markdown
Contributor Author

xing-yang commented Feb 11, 2019

@xing-yang could you seperate the PR out into two/three commits? One for API changes, one for generated code, one for any additional changes (if there are any).

This would make it much easier to review. Thanks!

Will do.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. area/apiserver labels Feb 12, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2019
@xing-yang
Copy link
Copy Markdown
Contributor Author

xing-yang commented Feb 27, 2019

@msau42 @thockin Addressed your comments. PodInfoOnMount is a bool now. I also squashed the commits down to two. PTAL.

@msau42 msau42 mentioned this pull request Feb 28, 2019
Merged
@xing-yang
Copy link
Copy Markdown
Contributor Author

xing-yang commented Feb 28, 2019

Rebased.

@xing-yang xing-yang force-pushed the csi_crd branch 2 times, most recently from 69cac92 to aa5150e Compare February 28, 2019 14:41
@xing-yang
Copy link
Copy Markdown
Contributor Author

xing-yang commented Feb 28, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@xing-yang
Copy link
Copy Markdown
Contributor Author

xing-yang commented Feb 28, 2019

/test pull-kubernetes-e2e-gce-100-performance

@jsafrane jsafrane mentioned this pull request Mar 1, 2019
Merged
@msau42 msau42 mentioned this pull request Mar 1, 2019
Closed
@thockin
Copy link
Copy Markdown
Member

thockin commented Mar 1, 2019

I'll shift any further comments to #74283

@thockin thockin added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2019
xing-yang added 2 commits March 2, 2019 12:31
@xing-yang
Make CSINodeInfo and CSIDriver Core APIs
bb45b8e 
This PR is the first step to transition CSINodeInfo and CSIDriver
CRD's to in-tree APIs. It adds them to the existing API group
“storage.k8s.io” as core storage APIs.
@xing-yang
Add generated files
743d3a2
@xing-yang
Copy link
Copy Markdown
Contributor Author

xing-yang commented Mar 2, 2019

Rebased.

@bertinatto
Copy link
Copy Markdown
Member

bertinatto commented Mar 4, 2019

I'm not super familiar with core APIs, but I reviewed this PR and it LGTM.

@msau42
Copy link
Copy Markdown
Member

msau42 commented Mar 4, 2019

/retest

xing-yang added a commit to xing-yang/kubernetes that referenced this pull request Mar 5, 2019
@xing-yang
CSINodeInfo/CSIDriver controller changes
6265f4f 
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
kubernetes#73883
@k8s-ci-robot k8s-ci-robot merged commit 743d3a2 into kubernetes:master Mar 5, 2019
@croomes croomes mentioned this pull request Jun 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane jsafrane left review comments

@thockin thockin thockin left review comments

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

+6 more reviewers

@gnufied gnufied gnufied left review comments

@kfox1111 kfox1111 kfox1111 left review comments

@davidz627 davidz627 davidz627 left review comments

@vishh vishh vishh left review comments

@ddebroy ddebroy ddebroy left review comments

@msau42 msau42 msau42 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@davidz627 davidz627

@thockin thockin

@msau42 msau42

Labels

area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.14

Development

Successfully merging this pull request may close these issues.