Skip to content

Promote NodeLease to Beta and enable by default#72096

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
wojtek-t:promote_node_lease
Dec 17, 2018
Merged

Promote NodeLease to Beta and enable by default#72096
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
wojtek-t:promote_node_lease

Conversation

@wojtek-t
Copy link
Copy Markdown
Member

@wojtek-t wojtek-t commented Dec 17, 2018 •
edited
Loading

Ref #14733
Ref https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/0009-node-heartbeat.md

Running tests at scale confirms that the main (of reducing size of etcd) has been achieved.
Without this change: etcd DB size: ~2.2GB
With this change: etcd DB size: ~1.3GB

Note that the tests were run on 5k nodes, but pretty much without any images being present on the node. And the more images on the nodes exist, the bigger impact we will have.
So the impact here is; ~2x+

@kubernetes/sig-node-pr-reviews @kubernetes/sig-scalability-pr-reviews @kubernetes/sig-api-machinery-pr-reviews
@mtaufen @wangzhen127 @liggitt @dchen1107 @yujuhong @lavalamp @bgrant0607 @gmarek

Promote NodeLease feature to Beta and enable it by default.
The feature make Lease object changes an additional healthiness signal from Node. Together with that, we reduce frequency of NodeStatus updates (from 10s to 1m by default) in case of no changes to status itself.

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 17, 2018
@wojtek-t wojtek-t added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 17, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@derekwaynecarr
Copy link
Copy Markdown
Member

derekwaynecarr commented Dec 17, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2018
@derekwaynecarr
Copy link
Copy Markdown
Member

derekwaynecarr commented Dec 17, 2018

FYI @sjennings

@k8s-ci-robot k8s-ci-robot merged commit f77a070 into kubernetes:master Dec 17, 2018
@dchen1107
Copy link
Copy Markdown
Member

dchen1107 commented Dec 17, 2018

Thanks!

@liggitt liggitt mentioned this pull request Dec 19, 2018
Closed
@wojtek-t wojtek-t mentioned this pull request Jan 17, 2019
Merged
@msau42 msau42 mentioned this pull request Jan 30, 2019
Closed
@wojtek-t wojtek-t added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 25, 2019
@wojtek-t wojtek-t mentioned this pull request Feb 25, 2019
Closed
6 tasks
rfranzke added a commit to gardener/gardener that referenced this pull request Mar 20, 2019
@rfranzke
Don't delete new kube-node-lease namespace during cluster cleanup
f1c4465 
See kubernetes/kubernetes#72096
rfranzke added a commit to gardener/gardener that referenced this pull request Mar 26, 2019
@rfranzke
Don't delete new kube-node-lease namespace during cluster cleanup
485c5c0 
See kubernetes/kubernetes#72096
rfranzke added a commit to gardener/gardener that referenced this pull request Mar 26, 2019
@rfranzke
Don't delete new kube-node-lease namespace during cluster cleanup
66221ff 
See kubernetes/kubernetes#72096
rfranzke added a commit to gardener/gardener that referenced this pull request Mar 26, 2019
@rfranzke
Don't delete new kube-node-lease namespace during cluster cleanup
fbfaf78 
See kubernetes/kubernetes#72096
rfranzke added a commit to gardener/gardener that referenced this pull request Mar 26, 2019
@rfranzke
Don't delete new kube-node-lease namespace during cluster cleanup
cf0be5a 
See kubernetes/kubernetes#72096
rfranzke added a commit to gardener/gardener that referenced this pull request Mar 26, 2019
@rfranzke
Don't delete new kube-node-lease namespace during cluster cleanup
5f5bc04 
See kubernetes/kubernetes#72096
rfranzke added a commit to gardener/gardener that referenced this pull request Mar 26, 2019
@rfranzke
Don't delete new kube-node-lease namespace during cluster cleanup
361588e 
See kubernetes/kubernetes#72096
This was referenced May 30, 2019
Merged
Merged
@wojtek-t wojtek-t deleted the promote_node_lease branch July 19, 2019 11:44
@lentil1016 lentil1016 mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@thockin thockin Awaiting requested review from thockin

Assignees

@liggitt liggitt

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wojtek-t @k8s-ci-robot @derekwaynecarr @dchen1107 @liggitt