tests: Fixes wrong Pod Container Image usage in test/e2e/apps#71256
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Nov 29, 2018
Merged
Conversation
Some tests are not using the configured registry image names, causing some tests to fail on Windows, since those images are Linux only.
Contributor
|
/ok-to-test |
ixdy
reviewed
Nov 26, 2018
| imageutils "k8s.io/kubernetes/test/utils/image" | ||
| ) | ||
|
|
||
| // NOTE(claudiub): These constants should NOT be used as Pod Container Images. |
Contributor
There was a problem hiding this comment.
wow, these constants are poorly named, though I'm not sure what a better name would be.
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bclau, ixdy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adelina-t
added a commit
to e2e-win/e2e-win-prow-deployment
that referenced
this pull request
Dec 5, 2018
kubernetes/kubernetes#71256 merged thus there is no need to exclude the following tests: [sig-apps] ReplicaSet should adopt matching pods on creation and release no longer matching pods [Conformance] [sig-apps] ReplicationController should adopt matching pods on creation [Conformance] kubernetes/kubernetes#71036 merged thus there is no need to exclude the following tests: [sig-storage] Secrets should be consumable from pods in volume [NodeConformance] [Conformance] [sig-storage] Secrets should be consumable from pods in volume with mappings [NodeConformance] [Conformance] [sig-storage] Secrets should be consumable in multiple volumes in a pod [NodeConformance] [Conformance] [sig-storage] Projected secret should be consumable from pods in volume [NodeConformance] [Conformance] [sig-storage] Projected secret should be consumable from pods in volume with mappings [NodeConformance] [Conformance] [sig-storage] Projected secret should be consumable in multiple volumes in a pod [NodeConformance] [Conformance] [sig-storage] Projected configMap should be consumable from pods in volume [NodeConformance] [Conformance] [sig-storage] Projected configMap should be consumable from pods in volume with mappings [NodeConformance] [Conformance] [sig-storage] ConfigMap should be consumable from pods in volume [NodeConformance] [Conformance] [sig-storage] ConfigMap should be consumable from pods in volume with mappings [NodeConformance] [Conformance] [sig-storage] Secrets should be able to mount in a volume regardless of a different secret existing with same name in different namespace [NodeConformance] [Conformance] [sig-storage] Projected secret should be able to mount in a volume regardless of a different secret existing with same name in different namespace [NodeConformance]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
Some tests are not using the configured registry image names, causing
some tests to fail on Windows, since those images are Linux only.
This test fixes the following tests when using Windows nodes:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related issue: #60487
Special notes for your reviewer:
Does this PR introduce a user-facing change?: