Skip to content

Use the v1.12 branch by default#68789

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
timothysc:kubeadm-1.12
Sep 21, 2018
Merged

Use the v1.12 branch by default#68789
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
timothysc:kubeadm-1.12

Conversation

@timothysc
Copy link
Copy Markdown
Contributor

@timothysc timothysc commented Sep 18, 2018

Final update for kubeadm 1.12 default switching.

/cc @kubernetes/sig-cluster-lifecycle-pr-reviews @kubernetes/sig-release-members
/assign @tpepper
/lgtm
/approve

@tpepper unhold when ready to cut RC!

@timothysc timothysc added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 18, 2018
@timothysc timothysc added this to the v1.12 milestone Sep 18, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 18, 2018

@timothysc: you cannot LGTM your own PR.

Details

In response to this:

Final update for kubeadm 1.12 default switching.

/cc @kubernetes/sig-cluster-lifecycle-pr-reviews @kubernetes/sig-release-members
/assign @tpepper
/lgtm
/approve

@tpepper unhold when ready to cut RC!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 18, 2018

@timothysc: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 18, 2018
@timothysc timothysc added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 18, 2018
@timothysc
Copy link
Copy Markdown
Contributor Author

timothysc commented Sep 18, 2018 •
edited
Loading

/test pull-kubernetes-bazel-test
/test pull-kubernetes-integration

Just as a reminder, merging this change will make some tests fail for a while until release is actually cut.
This is a known-known.

@timothysc
Copy link
Copy Markdown
Contributor Author

timothysc commented Sep 18, 2018

Hah, the test failure highlights my previous message
unable to fetch file. URL: "https://dl.k8s.io/release/stable-1.12.txt", status: 404 Not Found

@tpepper
Copy link
Copy Markdown

tpepper commented Sep 19, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2018
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 19, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@tpepper
Copy link
Copy Markdown

tpepper commented Sep 19, 2018

/retest

@tpepper
Copy link
Copy Markdown

tpepper commented Sep 19, 2018

Do we normally force push this patch? Ie: that endpoint really doesn't resolve until 1.12.0 tag is pushed. Looks like comparable last time didn't need that: #65229

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 19, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

2 similar comments
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 19, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 19, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@neolit123
Copy link
Copy Markdown
Member

neolit123 commented Sep 19, 2018 •
edited
Loading

@timothysc
do we also have to bump the version in kubeadm/v1alpha2/defaults.go?

@neolit123
Copy link
Copy Markdown
Member

neolit123 commented Sep 19, 2018

@tpepper

Do we normally force push this patch? Ie: that endpoint really doesn't resolve until 1.12.0 tag is pushed. Looks like comparable last time didn't need that: #65229

v1.11.0 was tagged ~10 days after #65229 was merged.
not sure how that worked. 🤔

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 19, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 19, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@neolit123
Copy link
Copy Markdown
Member

neolit123 commented Sep 19, 2018

/lgtm cancel
to stop the bot auto-testing, for now

/hold
we need to sync with sig-docs on when the reference docs are generated.
we also need to understand why the endpoint is still missing. in previous cycles it seems that this PR is viable for RC1.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 19, 2018
@tpepper
Copy link
Copy Markdown

tpepper commented Sep 20, 2018 •
edited
Loading

I can't find any discussion in Slack history, but I feel like somebody may have done something back in June to magically fix this for 1.11?

@AishSundar
Copy link
Copy Markdown
Contributor

AishSundar commented Sep 20, 2018

/cc @jberkus

May be @jberkus can provide some insight of how this went in 1.11?

@timothysc
Use the v1.12 branch by default
ee35211 
Signed-off-by: Timothy St. Clair <timothysc@gmail.com>
@timothysc
Copy link
Copy Markdown
Contributor Author

timothysc commented Sep 20, 2018

/test pull-kubernetes-e2e-gce-device-plugin-gpu

2 similar comments
@dims
Copy link
Copy Markdown
Member

dims commented Sep 20, 2018

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@dims
Copy link
Copy Markdown
Member

dims commented Sep 21, 2018

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@neolit123
Copy link
Copy Markdown
Member

neolit123 commented Sep 21, 2018

/retest

@timothysc timothysc removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2018
@timothysc
Copy link
Copy Markdown
Contributor Author

timothysc commented Sep 21, 2018

This one should be good to go and if we need to cherry-pick an update later in 1.13 it should be ok.

@AishSundar
Copy link
Copy Markdown
Contributor

AishSundar commented Sep 21, 2018

@timothysc did you mean cherrypick into 1.12 ?

@neolit123 neolit123 mentioned this pull request Sep 21, 2018
Merged
@dims
Copy link
Copy Markdown
Member

dims commented Sep 21, 2018

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@timothysc
Copy link
Copy Markdown
Contributor Author

timothysc commented Sep 21, 2018

self re-applying, we need to get this through.

@timothysc timothysc added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2018
@dims
Copy link
Copy Markdown
Member

dims commented Sep 21, 2018

/lgtm

Ack @timothysc

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7568f21 into kubernetes:master Sep 21, 2018
@neolit123 neolit123 mentioned this pull request Sep 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jberkus jberkus Awaiting requested review from jberkus

Assignees

@dims dims

@neolit123 neolit123

@tpepper tpepper

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

7 participants

@timothysc @k8s-ci-robot @tpepper @fejta-bot @neolit123 @AishSundar @dims