Skip to content

Added default tolerations for new pods.#68494

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k82cn:k8s_67606_2
Sep 11, 2018
Merged

Added default tolerations for new pods.#68494
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k82cn:k8s_67606_2

Conversation

@k82cn
Copy link
Copy Markdown
Contributor

@k82cn k82cn commented Sep 11, 2018 •
edited
Loading

Signed-off-by: Da K. Ma klaus1982.cn@gmail.com

Part of #67606

Release note:

None

@k82cn
Added default tolerations for new pods.
55199a0 
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 11, 2018
@k82cn
Copy link
Copy Markdown
Contributor Author

k82cn commented Sep 11, 2018

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Sep 11, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 11, 2018
@k82cn
Copy link
Copy Markdown
Contributor Author

k82cn commented Sep 11, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 11, 2018
@k82cn
Copy link
Copy Markdown
Contributor Author

k82cn commented Sep 11, 2018 •
edited
Loading

In DaemonSet e2e test (test/e2e/apps/daemon_set.go), it will check whether all Daemon Pods are running; but it use NewPod + Predicates (https://github.com/kubernetes/kubernetes/blob/master/test/e2e/apps/daemon_set.go#L610) which lost default tolerations.

But not sure why it failed after #64954 :(

@k82cn
Copy link
Copy Markdown
Contributor Author

k82cn commented Sep 11, 2018

/sig test

@k82cn k82cn mentioned this pull request Sep 11, 2018
Closed
@k82cn
Copy link
Copy Markdown
Contributor Author

k82cn commented Sep 11, 2018

/assign @janetkuo @mikedanese

@AishSundar
Copy link
Copy Markdown
Contributor

AishSundar commented Sep 11, 2018

/milestone v1.12

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 11, 2018
@tpepper
Copy link
Copy Markdown

tpepper commented Sep 11, 2018

/priority critical-urgent

This is likely release blocking.

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 11, 2018
@janetkuo
Copy link
Copy Markdown
Member

janetkuo commented Sep 11, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 11, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2018
@Huang-Wei
Copy link
Copy Markdown
Member

Huang-Wei commented Sep 11, 2018

/retest

@dougm
Copy link
Copy Markdown
Member

dougm commented Sep 11, 2018

/retest

dougm
dougm reviewed Sep 11, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for this to get merged before starting the beta.2 build this afternoon.

@k8s-ci-robot k8s-ci-robot merged commit 45c5ddd into kubernetes:master Sep 11, 2018
@k82cn k82cn deleted the k8s_67606_2 branch September 11, 2018 22:11
This was referenced Sep 12, 2018
Merged
Closed
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 14, 2018
@k8s-ci-robot
Merge pull request #68601 from k82cn/automated-cherry-pick-of-#66082-#…
ed30179 
…64954-#68494-upstream-release-1.11

Automated cherry pick of #66082: move feature gate checks inside IsCriticalPod #64954: Added unschedulable and network-unavailable toleration. #68494: Added default tolerations for new pods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikedanese mikedanese Awaiting requested review from mikedanese

2 more reviewers

@dougm dougm dougm left review comments

@janetkuo janetkuo janetkuo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikedanese mikedanese

@janetkuo janetkuo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

8 participants

@k82cn @AishSundar @tpepper @janetkuo @k8s-ci-robot @Huang-Wei @dougm @mikedanese