Fix docker registry used in e2e test.#67061
Fix docker registry used in e2e test.#67061k8s-github-robot merged 1 commit intokubernetes:masterfrom
Conversation
|
/lgtm |
test/utils/image/manifest.go
Outdated
There was a problem hiding this comment.
This is true only for the images which are present in docker library, so the library should come in imagename and not in dockerHubRegistry registry.
There was a problem hiding this comment.
The nginx images are the only use of this const at the moment. Is it necessary to draw that distinction? The goal here is to handle docker and containerd’s normalization.
There was a problem hiding this comment.
@cblecker 3 of them, not just 2.
- community docker
- docker in RHEL
- containerd
There was a problem hiding this comment.
@mkumatag Please take a look at all registries below, all of them include the full "namespace":
e2eRegistry = "gcr.io/kubernetes-e2e-test-images"
gcRegistry = "k8s.gcr.io"
PrivateRegistry = "gcr.io/k8s-authenticated-test"
sampleRegistry = "gcr.io/google-samples"
We can change dockerHubRegistry to dockerLibraryRegistry if that is preferred.
There was a problem hiding this comment.
I'm okay with renaming to dockerLibraryRegistry
|
/hold |
|
@mkumatag The test is failing for several days. Can we bring it back to green sooner? Are you ok with #67061 (comment)? |
|
+1 to dockerLibraryRegistry |
|
I'm good with that approach as well. Please ping when the change is complete, @Random-Liu :) |
4df2fdb to
e232c4f
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, Random-Liu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-kubernetes-integration |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
See #66055 (comment).
Fix docker registry used in e2e test, so that it works with all container runtimes.
Release note:
/cc @kubernetes/sig-node-pr-reviews @kubernetes/sig-testing-pr-reviews