Skip to content

Bring StorageObjectInUseProtection feature to GA#62870

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
pospispa:Bring-StorageObjectInUseProtection-feature-to-GA-2nd-attempt
Apr 27, 2018
Merged

Bring StorageObjectInUseProtection feature to GA#62870
k8s-github-robot merged 1 commit intokubernetes:masterfrom
pospispa:Bring-StorageObjectInUseProtection-feature-to-GA-2nd-attempt

Conversation

@pospispa
Copy link
Copy Markdown
Contributor

@pospispa pospispa commented Apr 19, 2018

What this PR does / why we need it:
It brings StorageObjectInUseProtection feature to GA.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes N/A

Special notes for your reviewer:
Related features: kubernetes/enhancements#498 and kubernetes/enhancements#499
Related PR: #61324

Release note:

StorageObjectInUseProtection feature is GA.

@pospispa
Bring StorageObjectInUseProtection feature to GA
c598682 
StorageObjectInUseProtection is Beta in K8s 1.10.

It's brought to GA in K8s 1.11.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 19, 2018
@pospispa
Copy link
Copy Markdown
Contributor Author

pospispa commented Apr 19, 2018

/sig storage
/kind feature
@tsmetana @jsafrane @NickrenREN @msau42 PTAL
/cc @saad-ali

@k8s-ci-robot k8s-ci-robot requested a review from saad-ali April 19, 2018 18:44
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 19, 2018
This was referenced Apr 19, 2018
Closed
Closed
@NickrenREN
Copy link
Copy Markdown
Contributor

NickrenREN commented Apr 20, 2018

/retest

@pospispa
Copy link
Copy Markdown
Contributor Author

pospispa commented Apr 21, 2018

@liggitt
I'd like to bring the StorageObjectInUse feature into GA. You adviced me here that for bringing the feature into GA I should just flip the feature status. So I'm proposing it in this PR. Please, would you review it?

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Apr 23, 2018

lgtm, sig-storage has approval

@pospispa pospispa mentioned this pull request Apr 23, 2018
Merged
@jsafrane
Copy link
Copy Markdown
Member

jsafrane commented Apr 25, 2018

/lgtm
from sig-storage PV

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2018
@jsafrane
Copy link
Copy Markdown
Member

jsafrane commented Apr 25, 2018

@childsb, @saad-ali, can you please approve?

@pospispa
Copy link
Copy Markdown
Contributor Author

pospispa commented Apr 25, 2018

/retest

@childsb
Copy link
Copy Markdown
Contributor

childsb commented Apr 26, 2018

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, jsafrane, pospispa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2018
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Apr 26, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Apr 26, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Apr 26, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Apr 27, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 6abbab4 into kubernetes:master Apr 27, 2018
@tengqm tengqm mentioned this pull request May 3, 2018
Merged
@skriss skriss mentioned this pull request May 8, 2018
Closed
@ikeeip ikeeip mentioned this pull request Sep 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@lavalamp lavalamp Awaiting requested review from lavalamp

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@jsafrane jsafrane

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@pospispa @NickrenREN @liggitt @jsafrane @childsb @k8s-ci-robot @fejta-bot @k8s-github-robot