Bring StorageObjectInUseProtection feature to GA#61325
Bring StorageObjectInUseProtection feature to GA#61325pospispa wants to merge 1 commit intokubernetes:masterfrom
Conversation
StorageObjectInUseProtection is Beta in K8s 1.10. It's brought to GA in K8s 1.11.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pospispa Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/sig storage |
|
@pospispa: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| } | ||
|
|
||
| func startPVCProtectionController(ctx ControllerContext) (bool, error) { | ||
| if utilfeature.DefaultFeatureGate.Enabled(features.StorageObjectInUseProtection) { |
There was a problem hiding this comment.
We don't typically remove the gate to go GA, we flip the feature status, and that's it.
| // beta: v1.10 | ||
| // | ||
| // Postpone deletion of a PV or a PVC when they are being used | ||
| StorageObjectInUseProtection utilfeature.Feature = "StorageObjectInUseProtection" |
There was a problem hiding this comment.
Removal of a gate breaks startups that explicitly enabled it. I'd expect this to remain, with GA status, either indefinitely, or for an announced deprecation period
|
@NickrenREN mentioned that it'd be better to firstly combine code of the |
|
I will send out a PR for that |
|
PR: #61385 |
What this PR does / why we need it:
It brings
StorageObjectInUseProtectionfeature to GA.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes N/A
Special notes for your reviewer:
Release note: