publish node components version information#6211
Merged
vmarmol merged 2 commits intokubernetes:masterfrom Mar 31, 2015
Merged
Conversation
pkg/kubelet/kubelet.go
Outdated
Contributor
There was a problem hiding this comment.
I think we don't need this function, we can probably call cAdvisor directly above. We only export the information through status anyways.
Member
Author
There was a problem hiding this comment.
Yeah, removed it. Thanks!
Contributor
|
Thanks @dchen1107! Minor comment, LGTM otherwise. |
Contributor
|
LGTM, we can squash the last commit and merge on green :) |
Member
Author
|
Done with squash! |
vmarmol
added a commit
that referenced
this pull request
Mar 31, 2015
publish node components version information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, kubectl describe nodes id includes related version info.
Running: cluster/../cluster/gce/../../cluster/../_output/dockerized/bin/linux/amd64/kubectl describe nodes kubernetes-minion-4vox.c.golden-system-455.internal
Name: kubernetes-minion-4vox.c.golden-system-455.internal
Labels:
CreationTimestamp: Mon, 30 Mar 2015 16:20:29 -0700
Conditions:
Type Status LastProbeTime LastTransitionTime Reason Message
Ready True Tue, 31 Mar 2015 00:35:37 -0700 Mon, 30 Mar 2015 16:20:59 -0700 kubelet is posting ready status
Addresses: 130.211.182.208,104.197.28.200
Capacity:
cpu: 1
memory: 3800824Ki
Version:
Kernel Version: 3.16.0-0.bpo.4-amd64
OS Image: Debian GNU/Linux 7 (wheezy)
Container Runtime Version: docker://1.5.0
Kubelet Version: v0.14.0-10-g3e0cdff97c2e77-dirty
Kube-Proxy Version: v0.14.0-10-g3e0cdff97c2e77-dirty
ExternalID: 9471772650125516840
Pods: (2 in total)
fluentd-to-elasticsearch-kubernetes-minion-4vox
monitoring-influx-grafana-controller-240nz
Events:
FirstSeen LastSeen Count From SubobjectPath Reason Message
Tue, 31 Mar 2015 00:17:25 -0700 Tue, 31 Mar 2015 00:17:25 -0700 1 {kubelet kubernetes-minion-4vox.c.golden-system-455.internal} starting Starting kubelet.
Fix #5948