Add code in client package to use kubelet's API to retrieve data from cAdvisor#482
Conversation
|
There seems to be an update to cAdvisor mixed in with your changes? Does this need a rebase or something? Our dependency updating script should make separate commits when updating a dependency? |
|
@lavalamp Ah. Yes, I squashed all commits. I thought it was the default way. I think we don't need a rebase. I have already done it on my local machine. I did not use the updating script. (Not sure when we added this script. I thought there's only deps.sh.) |
There was a problem hiding this comment.
Put this all on one line?
|
LGTM, modulo the one small comment. |
|
Let's keep the dependency updating separate commits in the future-- makes it easier to see just your changes in the github interface. :) |
|
@brendandburns Thank you! Comment addressed. PTAL. |
Add code in client package to use kubelet's API to retrieve data from cAdvisor
|
Thank you, @brendandburns |
Remove stale comments.
Build script docker image when releasing
Build script docker image when releasing
Build script docker image when releasing
add pod deletion latency known issue
Add owners section for subproject owners
Cherry pick #482 from cloud provider azure: aggregate errors when putting vmss
This is the second piece of change in #448.
In this PR, I defined a new interface named
ContainerInfoGetterinpkg/clientpackage. One implementation of it isHTTPContainerInfoGetter, which will retrieve container information from cAdvisor through kubelet.