Ensures node becomes schedulable at the end of tests that delete nodes#48118
Ensures node becomes schedulable at the end of tests that delete nodes#48118k8s-github-robot merged 1 commit intokubernetes:masterfrom
Conversation
|
Hi @verult. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/sig-storage |
| podClient.Delete(host0Pod.Name, metav1.NewDeleteOptions(0)) | ||
| detachAndDeletePDs(diskName, []types.NodeName{host0Name}) | ||
| framework.WaitForNodeToBeReady(f.ClientSet, string(host0Name), nodeStatusTimeout) | ||
| framework.WaitForAllNodesSchedulable(f.ClientSet, nodeStatusTimeout) |
There was a problem hiding this comment.
Does this also wait for all nodes to be ready?
There was a problem hiding this comment.
Yes it does, but "all nodes" only include nodes that are known to kubelet, which may not include the deleted node. The previous line checks for that case.
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, msau42, verult Associated issue: 48008 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
I approve this one for improving test itself. Thanks! cc/ @kubernetes/kubernetes-release-managers |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue (batch tested with PRs 48118, 48159) |
|
@verult: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
What this PR does / why we need it: Further fixes the flakiness of "Pod Disk should be able to detach from a node which was deleted". When a node becomes ready but not schedulable, it was not included in the final node count.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #48008Special notes for your reviewer: Updated a similar test, "Pod Disk should be able to detach from a node whose api object was deleted", to use an "Expect" instead of a soft error because the test needs to guarantee that the environment is completely reset.
Release note: