enable docs and man page autogeneration for cloud-controller-manager#47934
enable docs and man page autogeneration for cloud-controller-manager#47934thockin merged 1 commit intokubernetes:masterfrom
Conversation
|
Hi @wlan0. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/ok-to-test |
|
Adding label:do-not-merge because PR changes docs prohibited to auto merge |
|
In terms of the content, docs lgtm. |
|
@chenopis What's needed to get a LGTM? Should I ping someone? |
|
Unfortunately, I'm not a maintainer of this repo, so I can't give the lgtm myself. Let's ping @thockin and @smarterclayton to see if they can do it. |
|
@dchen1107 Who else can do a tech review for this? |
|
@chenopis This looks good to me, but won't be able to auto merge right now because some of the paths are still defined as "old docs". I have kubernetes/test-infra#3175 open to modify that. Hopefully if that gets merged, then this change can be approved and merged by the bot. |
|
@cblecker Ok, great! Thanks for the update. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thockin, wlan0 Associated issue requirement bypassed by: thockin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
manual merge |
|
@k8s-bot test this Tests are more than 96 hours old. Re-running tests. |
|
@wlan0: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@chenopis These are docs for cloud-controller-manager.
PTAL