Skip to content

enable docs and man page autogeneration for cloud-controller-manager#47934

Merged
thockin merged 1 commit intokubernetes:masterfrom
wlan0:master
Jun 30, 2017
Merged

enable docs and man page autogeneration for cloud-controller-manager#47934
thockin merged 1 commit intokubernetes:masterfrom
wlan0:master

Conversation

@wlan0
Copy link
Copy Markdown
Contributor

@wlan0 wlan0 commented Jun 22, 2017

@chenopis These are docs for cloud-controller-manager.

PTAL

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2017
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @wlan0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 22, 2017
@cblecker
Copy link
Copy Markdown
Member

/ok-to-test
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 22, 2017
@k8s-github-robot
Copy link
Copy Markdown

Adding label:do-not-merge because PR changes docs prohibited to auto merge
See http://kubernetes.io/editdocs/ for information about editing docs

@k8s-github-robot k8s-github-robot added kind/old-docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jun 22, 2017
@chenopis
Copy link
Copy Markdown

In terms of the content, docs lgtm.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 23, 2017
@wlan0
Copy link
Copy Markdown
Contributor Author

wlan0 commented Jun 24, 2017

@chenopis What's needed to get a LGTM? Should I ping someone?

@chenopis
Copy link
Copy Markdown

Unfortunately, I'm not a maintainer of this repo, so I can't give the lgtm myself. Let's ping @thockin and @smarterclayton to see if they can do it.

@chenopis
Copy link
Copy Markdown

@dchen1107 Who else can do a tech review for this?

@cblecker
Copy link
Copy Markdown
Member

@chenopis This looks good to me, but won't be able to auto merge right now because some of the paths are still defined as "old docs". I have kubernetes/test-infra#3175 open to modify that. Hopefully if that gets merged, then this change can be approved and merged by the bot.

@chenopis
Copy link
Copy Markdown

@cblecker Ok, great! Thanks for the update.

@thockin
Copy link
Copy Markdown
Member

thockin commented Jun 30, 2017

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2017
@k8s-github-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, wlan0

Associated issue requirement bypassed by: thockin

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@thockin
Copy link
Copy Markdown
Member

thockin commented Jun 30, 2017

manual merge

@k8s-github-robot
Copy link
Copy Markdown

@k8s-bot test this

Tests are more than 96 hours old. Re-running tests.

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2017
@thockin thockin merged commit a0db287 into kubernetes:master Jun 30, 2017
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@wlan0: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-etcd3 38b060c link /test pull-kubernetes-e2e-gce-etcd3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants