Remove old-docs from blocked path#3175
Merged
0xmichalis merged 1 commit intokubernetes:masterfrom Aug 1, 2017
Merged
Conversation
Member
Author
|
@thockin Mind reviewing when you have a moment? |
This was referenced Jun 27, 2017
Merged
Member
|
lgtm, needs rebase. |
Contributor
|
Can we move this into a configmap and not mount it directly in the dockerfile? |
Member
Author
|
@Kargakis I'm totally okay with that.. except that I would want to detach the policy change (what this PR does) from the functional change (have this be a configmap instead of a file added to the docker image) |
Member
Author
|
@thockin rebased and tests pass |
Member
Author
|
@kubernetes/test-infra-maintainers This should be good to merge now :) |
Contributor
|
Sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per kubernetes/kubernetes#46813, we're removing a bunch of the static content from docs/ in k/k. This adjusts the paths of the old-docs munger to limit the amount of things that aren't allowed to be auto merged.