kubectl doesn't fail silently with no k8s master#4175
Merged
j3ffml merged 1 commit intokubernetes:masterfrom Feb 5, 2015
Merged
kubectl doesn't fail silently with no k8s master#4175j3ffml merged 1 commit intokubernetes:masterfrom
j3ffml merged 1 commit intokubernetes:masterfrom
Conversation
Contributor
|
lgtm. merging. |
j3ffml
added a commit
that referenced
this pull request
Feb 5, 2015
kubectl doesn't fail silently with no k8s master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the change, running cluster/kubectl.sh when there is no underlying Kubernetes master was failing silently. After this change this will write sth like that:
Project: groovy-sentry-504
Zone: us-central1-b
ERROR: (gcloud.compute.instances.describe) Could not fetch resource:
Also, this is making it consistent with cluster/kubecfg.sh
This change is part of fixing #3300