Skip to content

BestEffort QoS class has min cpu shares#41621

Merged
k8s-github-robot merged 1 commit into
kubernetes:masterfrom
derekwaynecarr:best-effort-qos-shares
Feb 26, 2017
Merged

BestEffort QoS class has min cpu shares#41621
k8s-github-robot merged 1 commit into
kubernetes:masterfrom
derekwaynecarr:best-effort-qos-shares

Conversation

@derekwaynecarr

Copy link
Copy Markdown
Member

What this PR does / why we need it:
BestEffort QoS class is given the minimum amount of CPU shares per the QoS design.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2017
@k8s-reviewable

Copy link
Copy Markdown

This change is Reviewable

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Feb 17, 2017
@derekwaynecarr

Copy link
Copy Markdown
Member Author

/cc @sjenning @vishh @dashpole

this statically assigns min shares value to BestEffort QoS cgroup. once @sjenning pr lands #41149 , i plan to plug-in dynamic share setting for Burstable QoS class.

@derekwaynecarr derekwaynecarr added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Feb 17, 2017
@derekwaynecarr

Copy link
Copy Markdown
Member Author

@k8s-bot gce etcd3 e2e test this

@derekwaynecarr

Copy link
Copy Markdown
Member Author

@k8s-bot non-cri e2e test this

@vishh

vishh commented Feb 17, 2017

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2017
@derekwaynecarr

Copy link
Copy Markdown
Member Author

@k8s-bot test this

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2017
@k8s-github-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: derekwaynecarr, k8s-merge-robot, vishh

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@derekwaynecarr derekwaynecarr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2017
k8s-github-robot pushed a commit that referenced this pull request Feb 25, 2017
Automatic merge from submit-queue (batch tested with PRs 41714, 41510, 42052, 41918, 31515)

Disable cgroups-per-qos pending Burstable/cpu.shares being set

Disable cgroups-per-qos to allow kubemark problems to still be resolved.

Re-enable it once the following merge:
#41753
#41644
#41621

Enabling it before cpu.shares is set on qos tiers can cause regressions since Burstable and BestEffort pods are given equal time.
@derekwaynecarr

Copy link
Copy Markdown
Member Author

@k8s-bot kubemark e2e test this
@k8s-bot gci gce e2e test this

@k8s-github-robot

Copy link
Copy Markdown

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 28a8d78 into kubernetes:master Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants