Skip to content

Revert "[Kubelet] Delay deletion of pod from the API server until volumes are deleted"#41202

Merged
jessfraz merged 1 commit into
kubernetes:masterfrom
dashpole:revert-41095-deletion_pod_lifecycle
Feb 9, 2017
Merged

Revert "[Kubelet] Delay deletion of pod from the API server until volumes are deleted"#41202
jessfraz merged 1 commit into
kubernetes:masterfrom
dashpole:revert-41095-deletion_pod_lifecycle

Conversation

@dashpole

@dashpole dashpole commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

Reverts #41095. Unblock the submit queue.
@pwittrock

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2017
@k8s-reviewable

k8s-reviewable commented Feb 9, 2017

Copy link
Copy Markdown

This change is Reviewable

@k8s-github-robot

k8s-github-robot commented Feb 9, 2017

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

The following people have approved this PR: dashpole

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @vishh
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Feb 9, 2017
@dashpole

dashpole commented Feb 9, 2017

Copy link
Copy Markdown
Contributor Author

cc @jessfraz

@ncdc ncdc assigned vishh and unassigned ncdc Feb 9, 2017
@jessfraz

jessfraz commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

cool can merge when green unless you think just do it haha

@dashpole

dashpole commented Feb 9, 2017

Copy link
Copy Markdown
Contributor Author

We can wait for green.

@jessfraz

jessfraz commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

merging!

@jessfraz jessfraz merged commit ff87d13 into kubernetes:master Feb 9, 2017
@dashpole dashpole deleted the revert-41095-deletion_pod_lifecycle branch February 9, 2017 18:22
dashpole added a commit to dashpole/kubernetes that referenced this pull request Feb 15, 2017
@dashpole
Revert "Merge pull request kubernetes#41202 from dashpole/revert-4109…
1d38818 
…5-deletion_pod_lifecycle"

This reverts commit ff87d13, reversing
changes made to 46becf2.
ahakanbaba pushed a commit to ahakanbaba/kubernetes that referenced this pull request Feb 17, 2017
@dashpole @ahakanbaba
Revert "Merge pull request kubernetes#41202 from dashpole/revert-4109…
65a6e89 
…5-deletion_pod_lifecycle"

This reverts commit ff87d13, reversing
changes made to 46becf2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vishh vishh

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dashpole @k8s-reviewable @k8s-github-robot @jessfraz @ncdc @vishh @k8s-ci-robot