Skip to content

Make kubernetes-src.tar.gz contain source code again#36407

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
ixdy:fix-source-tarball
Nov 8, 2016
Merged

Make kubernetes-src.tar.gz contain source code again#36407
k8s-github-robot merged 1 commit intokubernetes:masterfrom
ixdy:fix-source-tarball

Conversation

@ixdy
Copy link
Contributor

@ixdy ixdy commented Nov 8, 2016 •
edited by roberthbailey
Loading

What this PR does / why we need it: This PR fixes kubernetes-src.tar.gz by reviving the logic for kube-source.tar.gz from before #30787.

Which issue this PR fixes: fixes #36403

@saad-ali @jbeda @zmerlynn

This change is Reviewable

@ixdy ixdy added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 8, 2016
@ixdy ixdy added this to the v1.5 milestone Nov 8, 2016
@saad-ali
Copy link
Member

saad-ali commented Nov 8, 2016

/lgtm but I'm not familiar with the build so @jbeda should probably take a look

@ixdy
Copy link
Contributor Author

ixdy commented Nov 8, 2016

Since I referenced it, the old logic I mostly copied:
https://github.com/jbeda/kubernetes/blob/06b1a9636dbc1d30b0d5f7c6a1f59194800bf3e1/build/common.sh#L452-L460
https://github.com/jbeda/kubernetes/blob/06b1a9636dbc1d30b0d5f7c6a1f59194800bf3e1/build/common.sh#L467

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 8, 2016

Jenkins GCE Node e2e failed for commit 8a7153571f2a6f3a349f81032ebbfd036ba8fef6. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 8, 2016
@zmerlynn
Copy link
Member

zmerlynn commented Nov 8, 2016

@k8s-bot node e2e test this

@zmerlynn zmerlynn added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2016
@k8s-github-robot
Copy link

k8s-github-robot commented Nov 8, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@ixdy
Copy link
Contributor Author

ixdy commented Nov 8, 2016

Thanks @zmerlynn . I don't think @jbeda will have a chance to look before the end of this week.

@ixdy
Copy link
Contributor Author

ixdy commented Nov 8, 2016

FYI this appears to be doing the right thing:

$ curl -s https://storage.googleapis.com/kubernetes-release-pull/ci/pull-kubernetes-e2e-gce/v1.6.0-alpha.0.184+db393f07f35044/kubernetes-src.tar.gz | tar tzvf - | wc -l
   13979

@ixdy ixdy force-pushed the fix-source-tarball branch from 8a71535 to d15b989 Compare November 8, 2016 19:52
@ixdy ixdy force-pushed the fix-source-tarball branch from d15b989 to 8b878b0 Compare November 8, 2016 19:58
@k8s-github-robot
Copy link

k8s-github-robot commented Nov 8, 2016

/lgtm cancel //PR changed after LGTM, removing LGTM. @ixdy @jbeda @saad-ali

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2016
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 8, 2016

Jenkins GCE etcd3 e2e failed for commit d15b98989a015db2ace19ca589d155ff13d9563b. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 8, 2016

Jenkins GCI GCE e2e failed for commit d15b98989a015db2ace19ca589d155ff13d9563b. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 8, 2016

Jenkins GCE e2e failed for commit d15b98989a015db2ace19ca589d155ff13d9563b. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 8, 2016

Jenkins GKE smoke e2e failed for commit d15b98989a015db2ace19ca589d155ff13d9563b. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@saad-ali
Copy link
Member

saad-ali commented Nov 8, 2016

Readding LGTM. Also ok for post-code freeze merge since this fixes a build issue.

@saad-ali saad-ali added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2016
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 8, 2016

Jenkins GCI GKE smoke e2e failed for commit d15b98989a015db2ace19ca589d155ff13d9563b. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 8, 2016

Jenkins Kubemark GCE e2e failed for commit d15b98989a015db2ace19ca589d155ff13d9563b. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 8, 2016

Jenkins unit/integration failed for commit d15b98989a015db2ace19ca589d155ff13d9563b. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@ixdy ixdy added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 8, 2016
@ixdy ixdy removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2016
@ixdy
Copy link
Contributor Author

ixdy commented Nov 8, 2016

I'm still working on something, let's not merge this yet.

@saad-ali
Copy link
Member

saad-ali commented Nov 8, 2016

I'm still working on something, let's not merge this yet.

Ack

@k8s-github-robot
Copy link

k8s-github-robot commented Nov 8, 2016

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 03348bb into kubernetes:master Nov 8, 2016
@ixdy
Copy link
Contributor Author

ixdy commented Nov 8, 2016

wtf SQ!

This was referenced Nov 8, 2016
Merged
Closed
k8s-github-robot pushed a commit that referenced this pull request Nov 8, 2016
Merge pull request #36459 from ixdy/fix-source-tarball
c8a5723 
Automatic merge from submit-queue

Fix find pattern in generating kubernetes src tarball

#36407 wasn't supposed to merge. This fixes a small issue in it.
@jbeda
Copy link
Contributor

jbeda commented Nov 15, 2016

I'm sorry I'm behind the ball here, but is there a reason not to use git archive here? I haven't used it before but it looks like exactly what we'd want. It looks to respect .gitignore and so we wouldn't need the funky find pattern.

@ixdy
Copy link
Contributor Author

ixdy commented Nov 15, 2016

If I'd known about git archive I might've used it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jbeda jbeda

@saad-ali saad-ali

Labels

do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.5

Development

Successfully merging this pull request may close these issues.

kubernetes-src.tar.gz contains no source code

7 participants

@ixdy @saad-ali @k8s-ci-robot @zmerlynn @k8s-github-robot @jbeda @googlebot