Cleanup to client initialization in Kubelet#3270
Merged
erictune merged 3 commits intokubernetes:masterfrom Jan 7, 2015
Merged
Conversation
Member
|
As people are fixing all the watch-related bugs, I'd really appreciate someone to take a look at kube2sky.go and see what mistakes I made :) |
cmd/kubelet/kubelet.go
Outdated
0eb7711 to
19ec202
Compare
cmd/kubelet/kubelet.go
Outdated
Contributor
There was a problem hiding this comment.
This is not a warning, since people use kubelets without an apiserver on purpose.
If you want to warn, then warn when apiServerList is non-empty, and it can't setup a client.
Contributor
|
@lavalamp can I take this review off your hands? |
Also fixes how Kubelet server looks up pods by name when there are multiple sources.
19ec202 to
ba53d72
Compare
Contributor
There was a problem hiding this comment.
This would be a fine place for a warning. Actually, a fatal seems fine with me.
Contributor
|
LGTM |
erictune
added a commit
that referenced
this pull request
Jan 7, 2015
Cleanup to client initialization in Kubelet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #846, @erictune this is all stuff you'll hit
@lavalamp review please