Solved data races in pkg/registry#306
Merged
lavalamp merged 2 commits intokubernetes:masterfrom Jun 30, 2014
Merged
Conversation
pkg/registry/mock_registry.go
Outdated
Contributor
There was a problem hiding this comment.
Maybe just a regular mutex? Or at least switch to using write locks for create/update?
Contributor
Author
There was a problem hiding this comment.
It seems that we did not change any member's value in create/update, so I used R(un)lock(). Anyway, I changed to Mutex now.
Contributor
There was a problem hiding this comment.
Haha, good point. Still, might as well be future-proof.
Contributor
Author
|
Changed to mutex. PTAL. |
Contributor
|
LGTM |
Contributor
Author
|
Thank you, @lavalamp. |
Contributor
Author
|
Good to merge? |
lavalamp
added a commit
that referenced
this pull request
Jun 30, 2014
Solved data races in pkg/registry
Contributor
|
Ah, just double checking our shiney new policy. I think this counts as a "small" change not needing to LGTMs. :) |
Contributor
Author
|
Thank you! |
vishh
pushed a commit
to vishh/kubernetes
that referenced
this pull request
Apr 6, 2016
This should make us more robust in the face of failure (at the cost of making the failures less prominent). We allow GetStats() to return an error and a partial result. We will process the result and report the error. Fixes kubernetes#306.
keontang
pushed a commit
to keontang/kubernetes
that referenced
this pull request
May 14, 2016
Remove kube-up complete report to executor
keontang
pushed a commit
to keontang/kubernetes
that referenced
this pull request
Jul 1, 2016
Remove kube-up complete report to executor
harryge00
pushed a commit
to harryge00/kubernetes
that referenced
this pull request
Aug 11, 2016
Remove kube-up complete report to executor
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Dec 8, 2016
Remove kube-up complete report to executor
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Mar 3, 2017
Remove kube-up complete report to executor
seans3
pushed a commit
to seans3/kubernetes
that referenced
this pull request
Apr 10, 2019
Initial incomplete release notes draft for 1.7
sttts
pushed a commit
to sttts/kubernetes
that referenced
this pull request
Aug 6, 2020
UPSTREAM: 93658: test/e2e: fail test rather than flooding logs if PVC watch is closed prematurely
b3atlesfan
pushed a commit
to b3atlesfan/kubernetes
that referenced
this pull request
Feb 5, 2021
etcd node and error return handling fixups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old version has a data race detected by
go test -race.