Looks like maybe I broke Jenkins. I'll debug tomorrow.

Build finished. 3357 tests run, 14 skipped, 0 failed.

Build finished.

Build finished. 330 tests run, 329 skipped, 0 failed.

/subscribe

I think it's worthy a release note since it breaks boot2docker

With respect to release note -- this will have zero impact on end users. It won't impact the release at all. I think that we want to announce it widely to everyone working on kubernetes itself but I don't think it needs a release note.

release notes are for things that affect end users, not developers, so I think release-note-none and a thread on kubernetes-dev are the way to go.

this is neat :)

@thockin -- wanted to make sure you saw this.

Moderately impactful for folks who don't run the VMs shipped by Docker, but it's not a deal breaker (it's just more config to make the default paths work, which most people do).

I'm running docker for mac (d4m)

Version 1.12.0-rc2-beta17 (build: 9779)
ff18c0c63c5ff3c4a4a925d191d5592d655779d7

and I do not see a file sharing tab. Do you have a sample screenshot of what that looks like?

Secondarily:
The docs mention needing 3G memory for a build. The default memory on d4m(at least for me on a 16G machine) is 2G, so there should be a mention of the slider or increasing memory access in the d4m use case.

Just tested this. Thanks for the cleanup @jbeda!
Next step would be to get make [WHAT=<pkgs>] to automatically run inside a docker container.

I have not reviewed it yet, but I am BEGGGGGGGING to not try to merge this until #25978 lands.

At that point, I agree whole-heartedly with @erictune that all builds, including 'make WHAT=foo' should run in Docker, thereby becoming significantly more hermetic.

Rebased. @thockin -- I'll wait until #25978 lands. Is there a timeline there?

Thanks for blocking. part 1 of 3 is in, part 2 is in queue. Part 3 has had partial review, but I will try to get it into queue tomorrow.

@jbeda PR needs rebase

GCE e2e build/test passed for commit d8ab401.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

@thockin -- are you ready for me to pick this up again and rehabilitate it?

go for it. I have no pending build changes at the moment.

On Mon, Aug 8, 2016 at 9:25 AM, Joe Beda notifications@github.com wrote:

@thockin https://github.com/thockin -- are you ready for me to pick
this up again and rehabilitate it?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#28518 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVJlJZ0nH6De0RXxNyezoJLHHwDoLks5qd1h7gaJpZM4JFqEF
.

cc @spxtr

@jbeda Needs a rebase. Would be great to have faster dockerized builds...

Not much to add. I'll give it a run after the rebase.

Reviewed 5 of 7 files at r1, 7 of 7 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

build/common.sh, line 248 [r2] (raw file):

      echo "    - Create and start your VM using docker-machine or docker for Mac: "
      echo "      - docker-machine create -d ${DOCKER_MACHINE_DRIVER} ${DOCKER_MACHINE_NAME}"
      echo "      - docker for Mac: check docker icon in menu bar"

maybe docker for Mac: run the Docker app and check for the Docker icon in the menu bar.
If the icon isn't there, the app needs to be run.

cluster/mesos/docker/util.sh, line 81 [r2] (raw file):

  if [[ "${entrypoint}" = "./"* ]]; then
    # relative to project root
    entrypoint="/go/src/github.com/GoogleCloudPlatform/kubernetes/${entrypoint}"

This doesn't seem right. I know you didn't change it, but I saw it out the corner of my eye. Is this function even used?

Comments from Reviewable

Closing this in favor of #30787. @MHBauer -- I'm going to look at your comments in light of that PR.