Skip to content

The remaining API changes for PodDisruptionBudget.#25551

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
mml:db.store.codegen
May 14, 2016
Merged

The remaining API changes for PodDisruptionBudget.#25551
k8s-github-robot merged 1 commit intokubernetes:masterfrom
mml:db.store.codegen

Conversation

@mml
Copy link
Copy Markdown
Contributor

@mml mml commented May 12, 2016

It's mostly the boilerplate required for the registry, some extra codegen, and a few tests.

Will squash once we're sure it's good.

@mml mml added this to the v1.3 milestone May 12, 2016
@mml mml added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. labels May 12, 2016
@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 12, 2016
@mml
Copy link
Copy Markdown
Contributor Author

mml commented May 12, 2016

Sigh. Looks like we changed this after 2ffa3b4

Climbing back into the hole...

@mml mml force-pushed the db.store.codegen branch from c528620 to 41ad9b9 Compare May 13, 2016 00:34
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2016
@mml mml force-pushed the db.store.codegen branch from 41ad9b9 to dfcc9ee Compare May 13, 2016 19:00
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2016
@mml mml force-pushed the db.store.codegen branch 2 times, most recently from 26c92f2 to 76f653f Compare May 13, 2016 22:23
@mml
Copy link
Copy Markdown
Contributor Author

mml commented May 13, 2016

@lavalamp this is passing now.

@lavalamp
Copy link
Copy Markdown
Contributor

LGTM, please squash.

Registry implementation and addition to the master.
@mml mml force-pushed the db.store.codegen branch from 76f653f to f5e8d41 Compare May 14, 2016 00:29
@mml mml added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2016
@mml
Copy link
Copy Markdown
Contributor Author

mml commented May 14, 2016

squashed. thanks for the review.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented May 14, 2016

GCE e2e build/test passed for commit f5e8d41.

@k8s-github-robot
Copy link
Copy Markdown

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented May 14, 2016

GCE e2e build/test passed for commit f5e8d41.

@k8s-github-robot
Copy link
Copy Markdown

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9796900 into kubernetes:master May 14, 2016
caseydavenport added a commit to caseydavenport/kubernetes that referenced this pull request May 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants