Skip to content

update node controller to use shared pod informer#24841

Merged
k8s-github-robot merged 2 commits intokubernetes:masterfrom
sjenning:shared-informer
Aug 2, 2016
Merged

update node controller to use shared pod informer#24841
k8s-github-robot merged 2 commits intokubernetes:masterfrom
sjenning:shared-informer

Conversation

@sjenning
Copy link
Copy Markdown
Contributor

@sjenning sjenning commented Apr 27, 2016

continuing work from #24470 and #23575

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Apr 27, 2016
@ncdc
Copy link
Copy Markdown
Member

ncdc commented Apr 27, 2016

cc @kubernetes/rh-cluster-infra @smarterclayton @deads2k @liggitt

@sjenning sjenning force-pushed the shared-informer branch 2 times, most recently from 635174e to 346a782 Compare April 27, 2016 15:38
@sjenning sjenning mentioned this pull request Apr 28, 2016
Merged
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Apr 29, 2016

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 29, 2016
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Apr 29, 2016

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@eparis I feel like the bot is trying to tell me something, but I don't know what.

@eparis eparis mentioned this pull request Apr 29, 2016
Closed
@eparis
Copy link
Copy Markdown
Contributor

eparis commented Apr 29, 2016

Its trying to tell you the github itself had major problems and the bot lost it's mind.

@eparis eparis removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 29, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2016
@smarterclayton smarterclayton added the sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. label May 1, 2016
@sjenning sjenning force-pushed the shared-informer branch from 346a782 to 51d2413 Compare May 4, 2016 20:47
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2016
@davidopp
Copy link
Copy Markdown
Contributor

davidopp commented May 15, 2016

not sure who is the best reviewer -- @lavalamp ? @wojtek-t ? @bprashanth ? Assigning to @wojtek-t for now.

@davidopp davidopp assigned wojtek-t and unassigned davidopp May 15, 2016
@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 20, 2016
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2016
0xmichalis
0xmichalis reviewed Jun 19, 2016
View reviewed changes
cmd/kube-controller-manager/app/controllermanager.go Outdated
Copy link
Copy Markdown
Contributor

@0xmichalis 0xmichalis Jun 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not update the deployment controller to share the pod cache just yet because it mutates its pod cache! I've opened #27687

@ghost
Copy link
Copy Markdown

ghost commented Jul 20, 2016

@mwielgus FYI, as this intersects with some stuff he's doing on Federation.

@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Jul 20, 2016

@quinton-hoole - I don't think so; this is something different

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2016
@sjenning sjenning changed the title update controllers to use shared pod informer update node controller to use shared pod informer Jul 20, 2016
@sjenning
Copy link
Copy Markdown
Contributor Author

sjenning commented Jul 20, 2016

Ok finally updated this. Dropped the deployment controller (see above why), rebased, refactored a change that introduced an incompatibility with the node controller using the shared informer.

@0xmichalis
Copy link
Copy Markdown
Contributor

0xmichalis commented Jul 20, 2016

@deads2k is the cache mutation detector enabled for Kube?

@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Jul 21, 2016

@Kargakis what is "cache mutation detector"?

@0xmichalis
Copy link
Copy Markdown
Contributor

0xmichalis commented Jul 21, 2016

@Kargakis what is "cache mutation detector"?

#27784

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Jul 21, 2016

@Kargakis what is "cache mutation detector"?

It allows detection of cache mutations based on an env var. It's not cheap to run, but its useful when running e2e style tests to find people who are messing with the cache. I'd really like to see it (or something that does the same job) merged.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. retest-not-required-docs-only and removed retest-not-required-docs-only labels Jul 28, 2016
@wojtek-t wojtek-t added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Aug 2, 2016
@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Aug 2, 2016

LGTM

@wojtek-t wojtek-t added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2016
@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 2, 2016

GCE e2e build/test passed for commit db6026c.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 2, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 2, 2016

GCE e2e build/test passed for commit db6026c.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 2, 2016

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 59836d6 into kubernetes:master Aug 2, 2016
@smarterclayton smarterclayton mentioned this pull request Aug 3, 2016
Closed
2 tasks
@xingzhou xingzhou mentioned this pull request Sep 6, 2016
Closed
@sjenning sjenning deleted the shared-informer branch November 21, 2016 16:20
@foxish foxish mentioned this pull request Jan 21, 2017
Closed
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Apr 10, 2020
@k8s-publishing-bot
Merge pull request kubernetes#24841 from rphillips/backports/24626_4.3
b18a959 
[release-4.3] Bug 1821341: UPSTREAM: 88440: Report deleted pod status correctly

Origin-commit: 21a4b974e162e4a2acfa77a03cf2e10986f12d48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wojtek-t wojtek-t

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.