Refactor kube auth#2340
Merged
smarterclayton merged 1 commit intokubernetes:masterfrom Nov 14, 2014
Merged
Conversation
17333c2 to
2126815
Compare
This was referenced Nov 13, 2014
Contributor
|
@deads2k can you review this? And then for the clientcmd stuff can you open a separate pull to upstream that introduces the utility functions so eric can review? |
Contributor
There was a problem hiding this comment.
err is guaranteed to be nil here. Returning "authPtr, nil" instead of "authPrt, err" might make it more clear.
2126815 to
e691bc7
Compare
Contributor
Author
|
@deads2k PTAL |
Contributor
|
I didn't tag the copy/paste methods between kubecfg and kubectl, but could you make the corresponding "return authPtr, nil" change in kubectl and the TODO in kubecfg? Otherwise, lgtm. |
e691bc7 to
f567766
Compare
Contributor
Author
|
Sure, done. |
Contributor
Author
|
This is ready for merge. |
Refactored common code to that package. Subsequent PRs will load and emit these files.
f567766 to
0727219
Compare
Contributor
Author
|
PTAL |
Contributor
|
LGTM |
Contributor
|
Sorry for delay. ----- Original Message -----
|
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 12, 2023
Implement Alpha state for KEP #2340
benluddy
pushed a commit
to benluddy/kubernetes
that referenced
this pull request
Jul 18, 2025
OCPBUGS-57886: Bump 4.19 1.32.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially resolves #2302