Skip to content

Add go-restful dependency#2222

Merged
bgrant0607 merged 1 commit intokubernetes:masterfrom
lavalamp:fix
Nov 12, 2014
Merged

Add go-restful dependency#2222
bgrant0607 merged 1 commit intokubernetes:masterfrom
lavalamp:fix

Conversation

@lavalamp
Copy link
Copy Markdown
Contributor

@lavalamp lavalamp commented Nov 7, 2014

Don't merge this.

@lavalamp
Copy link
Copy Markdown
Contributor Author

lavalamp commented Nov 7, 2014

@bgrant0607 here I finally got it working.

@bgrant0607
Copy link
Copy Markdown
Member

Awesome!!!

How?

@lavalamp
Copy link
Copy Markdown
Contributor Author

lavalamp commented Nov 7, 2014

symlinks don't work, I had to physically move my source tree into something that was in my GOPATH. Easily the most irritating thing I've found all day...

@bgrant0607
Copy link
Copy Markdown
Member

Argh. And then what commands did you execute?

@lavalamp
Copy link
Copy Markdown
Contributor Author

lavalamp commented Nov 7, 2014

First I did a dance with GOPATH that confuses even me.

Then I did godep restore, then godep get <thispackage>, then godep save ./...

...godep save didn't work until I put a go file in the tree which referenced this package.

Then I fixed the path it put in the Godeps.json file.

@lavalamp
Copy link
Copy Markdown
Contributor Author

lavalamp commented Nov 7, 2014

I filed #2220 because I'm pretty sure that our godep stuff is borked, btw.

@bgrant0607 bgrant0607 self-assigned this Nov 8, 2014
@bgrant0607
Copy link
Copy Markdown
Member

I'm far enough along to be convinced that we want to use go-restful, so I'd like to get this merged. However, it needs to be updated to the latest version, and it will probably need to be updated again soon.

Also, we need https://github.com/swagger-api/swagger-ui in order to get the javascript UI.

@bgrant0607
Copy link
Copy Markdown
Member

Note that the swagger-ui doesn't contain any Go code, though, so maybe it should go in third_party?

@bgrant0607
Copy link
Copy Markdown
Member

I'm punting on swagger-ui for now.

bgrant0607 added a commit that referenced this pull request Nov 12, 2014
Add go-restful dependency
@bgrant0607 bgrant0607 merged commit dd29cd8 into kubernetes:master Nov 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants