Add the client side bits of kubectl export functionality by brendandburns · Pull Request #18101 · kubernetes/kubernetes

brendandburns · 2015-12-02T20:22:12Z

@smarterclayton @bgrant0607 @janetkuo @kubernetes/kubectl

Ref: #13038

k8s-github-robot · 2015-12-02T20:28:10Z

Labelling this PR as size/XL

k8s-bot · 2015-12-02T20:52:10Z

GCE e2e test build/test passed for commit 323bdd7fad6a85b8db836fa7a5ea37aad078e1b6.

bgrant0607 · 2015-12-03T05:46:33Z

Assigned to @smarterclayton to choose a reviewer.

smarterclayton · 2015-12-03T21:13:44Z

@deads2k do you have bandwidth in the next day or two?

deads2k · 2015-12-04T13:29:06Z

@deads2k do you have bandwidth in the next day or two?

Yes, I'll look through.

deads2k · 2015-12-04T13:44:14Z

I'd like to see a test in test-cmd that demonstrates the field stripping effects of kubectl get --export.

Otherwise, just one nit on the second commit.

k8s-github-robot · 2015-12-17T13:43:16Z

Labelling this PR as size/M

deads2k · 2015-12-17T13:54:19Z

@brendandburns unit test failures are real.

deads2k · 2015-12-17T13:56:31Z

I'd still really like to see a test in test-cmd: #18101 (comment)

k8s-bot · 2015-12-17T13:58:52Z

GCE e2e test build/test passed for commit 5dc9655bd236ec22ee147d8440a520160048f66f.

k8s-bot · 2015-12-19T04:57:05Z

GCE e2e test build/test passed for commit 93de2be0366429eedc8539a588144fd3ff1ba99f.

k8s-bot · 2015-12-19T05:58:50Z

GCE e2e test build/test passed for commit 4ec17f828506ddbcf5b9b437f3f9a21e6ea28960.

brendandburns · 2015-12-21T20:45:05Z

@deads2k are you a git guru, I can't seem to figure out how to squash since the top commit is a merge...

deads2k · 2015-12-21T20:53:54Z

@deads2k are you a git guru, I can't seem to figure out how to squash since the top commit is a merge...

Sorry, I'm not a git guru, but something seems wrong. That "merge" commit is huge and seems to modify a bunch of files not in the diff for the pull request. Any chance its just a mistake and if you drop it your branch still has all the expected changes and works?

k8s-bot · 2015-12-21T21:09:55Z

GCE e2e test build/test passed for commit a7da25e5c45b1e1fb5aa079bfcfb9618054aa338.

brendandburns · 2015-12-21T21:22:59Z

@deads2k ok, I'll try to re-create this from scratch somehow...

brendandburns · 2015-12-21T21:25:47Z

@deads2k ok, I copied the test-cmd.sh changes into my clean-ish client on my mac and re-pushed. Hopefully that looks better.

--brendan

k8s-bot · 2015-12-21T22:06:45Z

GCE e2e test build/test passed for commit c051b019bc69c63525746f2cb857a2ee3f282383.

k8s-github-robot · 2015-12-22T08:19:01Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2015-12-22T08:52:01Z

GCE e2e build/test failed for commit c051b019bc69c63525746f2cb857a2ee3f282383.

0xmichalis · 2015-12-22T09:49:08Z

Summarizing 1 Failure:

[Fail] Services [It] should be able to up and down services 
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/service.go:244

Ran 116 of 208 Specs in 477.298 seconds
FAIL! -- 115 Passed | 1 Failed | 2 Pending | 90 Skipped

Probably a flake

wojtek-t · 2015-12-22T10:14:47Z

@k8s-bot e2e test this please

k8s-bot · 2015-12-22T10:47:37Z

GCE e2e test build/test passed for commit c051b019bc69c63525746f2cb857a2ee3f282383.

k8s-github-robot · 2015-12-22T18:45:10Z

PR changed after LGTM, removing LGTM.

spxtr · 2015-12-22T19:07:49Z

@k8s-bot unit test this please

#18960

k8s-bot · 2015-12-22T19:12:11Z

GCE e2e test build/test passed for commit 4123a61.

k8s-github-robot · 2015-12-29T18:26:29Z

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

k8s-bot · 2015-12-29T19:00:15Z

GCE e2e test build/test passed for commit 4123a61.

k8s-github-robot · 2015-12-29T19:06:33Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2015-12-29T19:42:17Z

GCE e2e test build/test passed for commit 4123a61.

k8s-github-robot · 2015-12-29T20:16:33Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2015-12-29T20:43:15Z

GCE e2e test build/test passed for commit 4123a61.

k8s-github-robot · 2015-12-29T20:43:42Z

Automatic merge from submit-queue

Auto commit by PR queue bot

googlebot added the cla: yes label Dec 2, 2015

k8s-github-robot assigned bgrant0607 Dec 2, 2015

k8s-github-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 2, 2015

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2015

bgrant0607 assigned smarterclayton and unassigned bgrant0607 Dec 3, 2015

deads2k assigned deads2k and unassigned smarterclayton Dec 4, 2015

0xmichalis mentioned this pull request Dec 16, 2015

kubectl export and clone #13038

Closed

brendandburns force-pushed the kubectl6 branch from 323bdd7 to 5dc9655 Compare December 17, 2015 13:25

brendandburns removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2015

k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 17, 2015

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2015

brendandburns force-pushed the kubectl6 branch from 5dc9655 to 93de2be Compare December 19, 2015 04:24

brendandburns force-pushed the kubectl6 branch 2 times, most recently from 4ec17f8 to f280b5b Compare December 19, 2015 05:37

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2015

brendandburns force-pushed the kubectl6 branch from a7da25e to c051b01 Compare December 21, 2015 21:25

deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2015

Add the client side bits of kubectl export

4123a61

brendandburns force-pushed the kubectl6 branch from c051b01 to 4123a61 Compare December 22, 2015 18:42

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2015

brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2015

k8s-github-robot pushed a commit that referenced this pull request Dec 29, 2015

Merge pull request #18101 from brendandburns/kubectl6

356487c

Auto commit by PR queue bot

k8s-github-robot merged commit 356487c into kubernetes:master Dec 29, 2015

0xmichalis mentioned this pull request Apr 27, 2016

Implement export functionality server-side for all resources #24855

Closed

3 tasks

Conversation

brendandburns commented Dec 2, 2015

Uh oh!

k8s-github-robot commented Dec 2, 2015

Uh oh!

k8s-bot commented Dec 2, 2015

Uh oh!

bgrant0607 commented Dec 3, 2015

Uh oh!

smarterclayton commented Dec 3, 2015

Uh oh!

deads2k commented Dec 4, 2015

Uh oh!

deads2k commented Dec 4, 2015

Uh oh!

k8s-github-robot commented Dec 17, 2015

Uh oh!

deads2k commented Dec 17, 2015

Uh oh!

deads2k commented Dec 17, 2015

Uh oh!

k8s-bot commented Dec 17, 2015

Uh oh!

k8s-bot commented Dec 19, 2015

Uh oh!

k8s-bot commented Dec 19, 2015

Uh oh!

brendandburns commented Dec 21, 2015

Uh oh!

deads2k commented Dec 21, 2015

Uh oh!

k8s-bot commented Dec 21, 2015

Uh oh!

brendandburns commented Dec 21, 2015

Uh oh!

brendandburns commented Dec 21, 2015

Uh oh!

k8s-bot commented Dec 21, 2015

Uh oh!

k8s-github-robot commented Dec 22, 2015

Uh oh!

k8s-bot commented Dec 22, 2015

Uh oh!

0xmichalis commented Dec 22, 2015

Uh oh!

wojtek-t commented Dec 22, 2015

Uh oh!

k8s-bot commented Dec 22, 2015

Uh oh!

k8s-github-robot commented Dec 22, 2015

Uh oh!

spxtr commented Dec 22, 2015

Uh oh!

k8s-bot commented Dec 22, 2015

Uh oh!

k8s-github-robot commented Dec 29, 2015

Uh oh!

k8s-bot commented Dec 29, 2015

Uh oh!

k8s-github-robot commented Dec 29, 2015

Uh oh!

k8s-bot commented Dec 29, 2015

Uh oh!

k8s-github-robot commented Dec 29, 2015

Uh oh!

k8s-bot commented Dec 29, 2015

Uh oh!

k8s-github-robot commented Dec 29, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants