Launch a browser when kubecfg is launched in proxy mode.#1680
Merged
Conversation
8501756 to
3d8f01f
Compare
Contributor
There was a problem hiding this comment.
Cool package for opening this stuff!
We should probably have an option to disable this. There are probably cases where users don't want this.
Also, is it cool to launch this before we start listening? This is probably a little race-y. Perhaps instead launch the 'Start' in a goroutine that first waits for a second or so?
Contributor
Author
There was a problem hiding this comment.
done and done.
Contributor
|
Please add dependencies and code in separate commits! |
69c3bfa to
9f13c73
Compare
Contributor
Author
|
Comments addressed. Please re-check. Thanks! |
Contributor
|
LGTM -- merging after travis passes. |
Contributor
Author
|
Fixed gofmt. It seems like the hooks are not run on a git rebase ... |
jbeda
added a commit
that referenced
this pull request
Oct 9, 2014
Launch a browser when kubecfg is launched in proxy mode.
imroc
pushed a commit
to imroc/kubernetes
that referenced
this pull request
Apr 8, 2026
…22.5' into 'tke/v1.22.5' (merge request !1681) Automated cherry pick of kubernetes#1680: Fix endpoints status out-of-sync when the pod state changes 功能：endpoints 更新不一致问题修复 社区 PR：kubernetes#125675 Cherry pick of kubernetes#1680 on tke/v1.22.5. kubernetes#1680: Fix endpoints status out-of-sync when the pod state changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.