Skip to content

KEP:5040 Lock gitRepo Volume Driver to disabled.#136400

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
vinayakankugoyal:gitrepo
Feb 12, 2026
Merged

KEP:5040 Lock gitRepo Volume Driver to disabled.#136400
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
vinayakankugoyal:gitrepo

Conversation

@vinayakankugoyal

@vinayakankugoyal vinayakankugoyal commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

Lock gitRepo Volume Driver to disabled.

Which issue(s) this PR is related to:

KEP: kubernetes/enhancements#5040

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Disabled git-repo volume plugin by default, with no option to turn it back on.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/5040

@k8s-ci-robot

k8s-ci-robot commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 21, 2026
@k8s-ci-robot

k8s-ci-robot commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 21, 2026
@vinayakankugoyal

vinayakankugoyal commented Jan 21, 2026

Copy link
Copy Markdown
Contributor Author

/test all

@vinayakankugoyal vinayakankugoyal mentioned this pull request Jan 21, 2026
Open
14 tasks
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 22, 2026
@vinayakankugoyal

vinayakankugoyal commented Jan 22, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@vinayakankugoyal vinayakankugoyal marked this pull request as ready for review January 24, 2026 03:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2026
@k8s-ci-robot k8s-ci-robot requested review from dims and jingxu97 January 24, 2026 03:02
@vinayakankugoyal

vinayakankugoyal commented Jan 25, 2026

Copy link
Copy Markdown
Contributor Author

/cc @thockin

@k8s-ci-robot k8s-ci-robot requested a review from thockin January 25, 2026 18:29
@vinayakankugoyal

vinayakankugoyal commented Jan 29, 2026

Copy link
Copy Markdown
Contributor Author

/cc @xing-yang

@vinayakankugoyal

vinayakankugoyal commented Jan 29, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@xing-yang

xing-yang commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

/retest

@saad-ali

saad-ali commented Feb 6, 2026

Copy link
Copy Markdown
Member

This PR is locking the feature gate disabling gitRepo per proposal in https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/5040-remove-gitrepo-driver/README.md#timeline

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2026
@k8s-ci-robot

k8s-ci-robot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: fcacc9ad2ba9a8fa32501aa1dd6be0f1ed59b5a0

@vinayakankugoyal

vinayakankugoyal commented Feb 7, 2026

Copy link
Copy Markdown
Contributor Author

/assing @thockin

thockin
thockin reviewed Feb 12, 2026
View reviewed changes

@thockin thockin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot

k8s-ci-robot commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, thockin, vinayakankugoyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2026
@k8s-ci-robot k8s-ci-robot merged commit 7f13600 into kubernetes:master Feb 12, 2026
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Feb 12, 2026
@kernel-kun kernel-kun mentioned this pull request Mar 27, 2026
Merged
@anshulg-dep-review anshulg-dep-review Bot mentioned this pull request May 24, 2026
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thockin thockin thockin left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@dims dims Awaiting requested review from dims

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@thockin thockin

@saad-ali saad-ali

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

5 participants

@vinayakankugoyal @k8s-ci-robot @xing-yang @saad-ali @thockin