Skip to content

node: kep-2625: cpu manager policy options GA#130535

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ffromani:cpumanager-policy-options-ga
Mar 20, 2025
Merged

node: kep-2625: cpu manager policy options GA#130535
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ffromani:cpumanager-policy-options-ga

Conversation

@ffromani
Copy link
Copy Markdown
Contributor

@ffromani ffromani commented Mar 3, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Move CPUManager Policy Options support to GA

Which issue(s) this PR fixes:

Fixes N/A

Special notes for your reviewer:

We need to merge #129950 before to this one
This and #129950 are both required for KEP 2625 to become GA

Does this PR introduce a user-facing change?

CPUManager Policy Options support is GA

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/2625

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet area/test labels Mar 3, 2025
@k8s-ci-robot k8s-ci-robot requested review from cici37 and dchen1107 March 3, 2025 10:03
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 3, 2025
@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 3, 2025
@ffromani ffromani mentioned this pull request Mar 3, 2025
Closed
12 tasks
@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Mar 3, 2025

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@ffromani ffromani force-pushed the cpumanager-policy-options-ga branch from 829d15a to a227602 Compare March 3, 2025 11:25
@k8s-ci-robot k8s-ci-robot added area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Mar 3, 2025
swatisehgal
swatisehgal reviewed Mar 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good wrt CPUManagerPolicyOptions. However, I was anticipating update of FullPCPUsOnlyOption to stable in this PR as well:

kubernetes/pkg/kubelet/cm/cpumanager/policy_options.go

Lines 48 to 53 in 8207fb4

betaOptions = sets.New[string](
FullPCPUsOnlyOption,
)
stableOptions = sets.New[string]()
)

Is this intentional and the plan is to do that in a separate PR? Why?

@ffromani
Copy link
Copy Markdown
Contributor Author

ffromani commented Mar 4, 2025

The changes look good wrt CPUManagerPolicyOptions. However, I was anticipating update of FullPCPUsOnlyOption to stable in this PR as well:

kubernetes/pkg/kubelet/cm/cpumanager/policy_options.go

Lines 48 to 53 in 8207fb4

betaOptions = sets.New[string](
FullPCPUsOnlyOption,
)
stableOptions = sets.New[string]()
)

Is this intentional and the plan is to do that in a separate PR? Why?

nope, just misstep on my side. Thanks for catching, will update.

@ffromani ffromani force-pushed the cpumanager-policy-options-ga branch from a227602 to d16615c Compare March 4, 2025 13:25
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 4, 2025
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Mar 5, 2025
@yongruilin
Copy link
Copy Markdown
Contributor

yongruilin commented Mar 6, 2025

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 6, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, liggitt, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
@BenTheElder BenTheElder mentioned this pull request Mar 19, 2025
Merged
@ffromani
Copy link
Copy Markdown
Contributor Author

ffromani commented Mar 19, 2025

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 19, 2025
@ffromani
Copy link
Copy Markdown
Contributor Author

ffromani commented Mar 19, 2025

need to review the feature gate testing logic. It likely breaks when multiple testcase are run in parallel. I added another testcase which is probably too much. Need to review this part.

@ffromani
node: kep-2625: cpu manager policy options GA
3c7ed00 
Move the support for CPUManager Policy Options to GA

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani ffromani force-pushed the cpumanager-policy-options-ga branch from 5924a3d to 3c7ed00 Compare March 20, 2025 07:32
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2025
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 20, 2025
@ffromani
Copy link
Copy Markdown
Contributor Author

ffromani commented Mar 20, 2025

/triage accepted
/priority important-soon

again from the context

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 20, 2025
swatisehgal
swatisehgal reviewed Mar 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 20, 2025

LGTM label has been added.

DetailsGit tree hash: 6f5e2fadeb312d592f1a8ac667c9dc9e165368fc

@ffromani
Copy link
Copy Markdown
Contributor Author

ffromani commented Mar 20, 2025

/hold cancel

fixed in the last upload

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6bc352f into kubernetes:master Mar 20, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 20, 2025
@ffromani ffromani mentioned this pull request Apr 5, 2025
Merged
@github-actions github-actions Bot mentioned this pull request Oct 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thockin thockin thockin left review comments

@cici37 cici37 Awaiting requested review from cici37

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@liggitt liggitt Awaiting requested review from liggitt

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

+2 more reviewers

@swatisehgal swatisehgal swatisehgal left review comments

@mrunalp mrunalp mrunalp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@saschagrunert saschagrunert

@liggitt liggitt

@SergeyKanzhelev SergeyKanzhelev

@swatisehgal swatisehgal

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

API Reviews
Status: API review completed, 1.33
SIG Node CI/Test Board
Archived in project

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.