Skip to content

Add tests for encoding collections in JSON for KEP-5116#130220

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
serathius:streaming-json-tests
Feb 24, 2025
Merged

Add tests for encoding collections in JSON for KEP-5116#130220
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
serathius:streaming-json-tests

Conversation

@serathius
Copy link
Copy Markdown
Contributor

@serathius serathius commented Feb 17, 2025 •
edited
Loading

Used test cases from:

For now testing current serializer implementation to show encoder behavior and agree on set of tests. Having a separate PR should make review easier. In separate PR will add the implementation for streaming that should provide same response byte-to-byte.

/kind feature

NONE

Previous PR #129334
Tracked in kubernetes/enhancements#5116

/assign @liggitt @deads2k @benluddy

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 17, 2025
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 17, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 17, 2025

@serathius: GitHub didn't allow me to assign the following users: dead2k.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

Used test cases from:

For now testing current serializer implementation to show encoder behavior and agree on set of tests. Having a separate PR should make review easier. In separate PR will add the implementation for streaming that should provide same response byte-to-byte.

/kind feature

NONE

Previous PR #129334
Tracked in kubernetes/enhancements#5116

/assign @liggitt @Dead2K @benluddy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 17, 2025
@serathius serathius mentioned this pull request Feb 17, 2025
Closed
14 tasks
@serathius
Copy link
Copy Markdown
Contributor Author

serathius commented Feb 17, 2025

/assign @deads2k

@serathius serathius force-pushed the streaming-json-tests branch 4 times, most recently from 2a718b6 to 9fbf4bf Compare February 18, 2025 09:16
@serathius
Add tests for encoding collections in JSON for KEP-5116
26fe6bc 
Used test cases from:
* Original PR kubernetes#129334
* KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/5116-streaming-response-encoding#unit-tests

For now testing current serializer implementation to show encoder
behavior and agree on set of tests. Having a separate PR should make review easier.
In separate PR will add the implementation for streaming that should
provide same response byte-to-byte.
@serathius serathius force-pushed the streaming-json-tests branch from 9fbf4bf to 26fe6bc Compare February 18, 2025 09:19
@cici37
Copy link
Copy Markdown
Contributor

cici37 commented Feb 18, 2025

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 18, 2025
@serathius
Copy link
Copy Markdown
Contributor Author

serathius commented Feb 21, 2025

ping @liggitt @benluddy @deads2k

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Feb 21, 2025

/lgtm
/approve
/hold in case @deads2k or @benluddy wants to look, can unhold after today if there's no additional feedback

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 21, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 21, 2025

LGTM label has been added.

DetailsGit tree hash: 61f648272e7c372c2a425ad897d1d55568f71778

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2025
@serathius
Copy link
Copy Markdown
Contributor Author

serathius commented Feb 24, 2025 •
edited
Loading

PTAL @liggitt @deads2k @benluddy

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Feb 24, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2025
This was referenced Feb 24, 2025
Merged
Closed
@k8s-ci-robot k8s-ci-robot merged commit dc3021b into kubernetes:master Feb 24, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 24, 2025
@z1cheng z1cheng mentioned this pull request Mar 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@thockin thockin Awaiting requested review from thockin

Assignees

@liggitt liggitt

@benluddy benluddy

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

6 participants

@serathius @k8s-ci-robot @cici37 @liggitt @benluddy @deads2k