Skip to content

Bump kubedns and nodelocaldns to 1.24.0#129175

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
DamianSawicki:bumpKubeDNS-1-24-0
Dec 12, 2024
Merged

Bump kubedns and nodelocaldns to 1.24.0#129175
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
DamianSawicki:bumpKubeDNS-1-24-0

Conversation

@DamianSawicki

@DamianSawicki DamianSawicki commented Dec 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This can only be merged after the appropriate images are promoted (kubernetes/k8s.io#7607).

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The PR bumps kubedns and nodelocaldns. See e.g. kubernetes/dns#649, kubernetes/dns#656, and kubernetes/dns#654.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

This renames some coredns metrics, see https://github.com/coredns/coredns/blob/v1.11.0/plugin/forward/README.md#metrics.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@DamianSawicki
Bump kubedns and nodelocaldns to 1.24.0
f9d9649 
Signed-off-by: Damian Sawicki <dsawicki@google.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 12, 2024
@k8s-ci-robot

k8s-ci-robot commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 12, 2024
@k8s-ci-robot k8s-ci-robot requested review from MrHohn and bowei December 12, 2024 11:22
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 12, 2024
@DamianSawicki DamianSawicki mentioned this pull request Dec 12, 2024
Closed
MrHohn
MrHohn approved these changes Dec 12, 2024
View reviewed changes

@MrHohn MrHohn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2024
@k8s-ci-robot

k8s-ci-robot commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 6e8f5eea7d1e3b4b84cc15344145689a39ac0351

@k8s-ci-robot

k8s-ci-robot commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DamianSawicki, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2024
@DamianSawicki

DamianSawicki commented Dec 12, 2024

Copy link
Copy Markdown
Contributor Author

/retest

@DamianSawicki

DamianSawicki commented Dec 12, 2024

Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 1a1f522 into kubernetes:master Dec 12, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Dec 12, 2024
@aojea

aojea commented Dec 16, 2024

Copy link
Copy Markdown
Member

@DamianSawicki @marqc @bowei this broke all GCE jobs https://testgrid.k8s.io/sig-network-gce#gci-gce-serial-kube-dns

It seems there is an incompatibility change in new version unknown flag: --logtostderr

 ENDLOG for container kube-system:kube-dns-774f458686-mkwgw:dnsmasq
  I1213 03:32:16.105087 10982 kubectl_utils.go:128] Logs of kube-system/kube-dns-774f458686-mkwgw:sidecar on node bootstrap-e2e-minion-group-37sw
  I1213 03:32:16.105126 10982 kubectl_utils.go:129]  : STARTLOG
  unknown flag: --logtostderr
  Usage of /sidecar:
        --dnsmasq-addr string            address that the dnsmasq server is listening on (default "127.0.0.1")
        --dnsmasq-poll-interval-ms int   interval with which to poll dnsmasq for stats (default 5000)
        --dnsmasq-port int               port that the dnsmasq server is listening on (default 53)
        --log-flush-frequency duration   Maximum number of seconds between log flushes (default 5s)
        --probe string                   probe the given DNS server with the DNS name and export probe metrics and healthcheck URI. Specified as <label>,<server>,<dns name>[,<interval_seconds>][,<type>]. Healthcheck url will be exported under /healthcheck/<label>. interval_seconds is optional. This option may be specified multiple times to check multiple servers. <type> is one of ANY, A, AAAA, SRV. Example: 'mydns,127.0.0.1:53,example.com,10,A'. (default "[]")
        --prometheus-addr string         http address to bind metrics server to (default "0.0.0.0")
        --prometheus-namespace string    prometheus metric namespace (default "kubedns")
        --prometheus-path string         http path used to export metrics (default "/metrics")
        --prometheus-port int            http port to use to export prometheus metrics (default 10054)
    -v, --v Level                        number for the log level verbosity (default 0)
        --version version[=true]         Print version information and quit
        --vmodule moduleSpec             comma-separated list of pattern=N settings for file-filtered logging (only works for the default text log format)
  unknown flag: --logtostderr
  ENDLOG for container kube-system:kube-dns-774f458686-mkwgw:sidecar
  [FAILED] in [SynchronizedBeforeSuite] - k8s.io/kubernetes/test/e2e/e2e.go:232 @ 12/13/24 03:32:16.105
  << Timeline

or maybe is brought by a dependency update in klog? I don't know but if you are going to bump dependencies here you must check the testgrid jobs https://testgrid.k8s.io/sig-network-gce#gci-gce-serial-kube-dns and trigger a presubmit before updating

This was referenced Dec 16, 2024
Closed
Merged
@DamianSawicki

DamianSawicki commented Dec 16, 2024

Copy link
Copy Markdown
Contributor Author

@DamianSawicki @marqc @bowei this broke all GCE jobs https://testgrid.k8s.io/sig-network-gce#gci-gce-serial-kube-dns

Oh no, I'm very sorry for that @aojea! Many thanks for creating a revert, I already LGTMed it.

if you are going to bump dependencies here you must check the testgrid jobs https://testgrid.k8s.io/sig-network-gce#gci-gce-serial-kube-dns and trigger a presubmit before updating

I'll update https://github.com/kubernetes/dns?tab=readme-ov-file#release-process accordingly. What specifically do you mean by "trigger a presubmit"? I see some /retest and /test pull-kubernetes-integration commands above, so it would appear that this PR was tested before submission.

@DamianSawicki DamianSawicki mentioned this pull request Dec 16, 2024
Merged
@DamianSawicki

DamianSawicki commented Dec 16, 2024

Copy link
Copy Markdown
Contributor Author

Ok, we clarified with Antonio elsewhere that the presubmit didn't exist, so it was impossible to automatically detect the problem before merging. Such a presubmit will be added in kubernetes/test-infra#33962 and the release instruction will be updated in kubernetes/dns#664.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bowei bowei Awaiting requested review from bowei

1 more reviewer

@MrHohn MrHohn MrHohn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MrHohn MrHohn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

4 participants

@DamianSawicki @k8s-ci-robot @aojea @MrHohn