docs: Presubmit triggering and grid validation in README#Release process#664
Conversation
|
/cc @aojea |
51fc642 to
d1a68eb
Compare
|
/lgtm as a follow up we may want to inrtoduce the optional presubmit so we don't risk to have to revert after merge |
This adds to the release instructions in README.md that a presubmit should be triggered before bumping kubedns or nodecache versions in kubernetes/kubernetes and the test grid should be verified afterwards. Signed-off-by: Damian Sawicki <dsawicki@google.com>
d1a68eb to
78bb2dd
Compare
|
/test |
|
@DamianSawicki: The
Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test all |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, DamianSawicki, kl52752, marqc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds to the release instructions in
README.mdthat a presubmitshould be triggered before bumping kubedns or nodecache (
cluster/addons/dns/) versions inkubernetes/kubernetes and the test grid https://testgrid.k8s.io/sig-network-gce#gci-gce-serial-kube-dns (and other related tabs) should be verified afterwards. This should prevent issues like kubernetes/kubernetes#123590 and kubernetes/kubernetes#129230 from happening in the future and/or speed up their detection.