Skip to content

Revert "Update kubedns and nodelocaldns to v1.23.0"#123590

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
aojea:revert-123310-update/dns/v1.23.0
Feb 29, 2024
Merged

Revert "Update kubedns and nodelocaldns to v1.23.0"#123590
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
aojea:revert-123310-update/dns/v1.23.0

Conversation

@aojea

@aojea aojea commented Feb 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Reverts #123310

I0228 19:32:34.820278 10025 dump.go:53] At 2024-02-28 19:19:36 +0000 UTC - event for node-local-dns-fdhmh: {kubelet e2e-cc361f69af-1186e-minion-group-60n8} Pulling: Pulling image "registry.k8s.io/dns/k8s-dns-node-cache:1.23.0"
615

all networking dns jobs are failing because of this https://testgrid.k8s.io/sig-network-gce#gci-gce-coredns-nodecache

We need to promote the image before doing the changes to the manifest

/assign @xmudrii @dims @liggitt
/cc @MrHohn @bzsuni @kl52752

NONE

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 29, 2024
@k8s-ci-robot

k8s-ci-robot commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 29, 2024
@aojea

aojea commented Feb 29, 2024

Copy link
Copy Markdown
Member Author

/sig network
/sig testing

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 29, 2024
@aojea

aojea commented Feb 29, 2024

Copy link
Copy Markdown
Member Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 29, 2024
@dims

dims commented Feb 29, 2024

Copy link
Copy Markdown
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2024
@k8s-ci-robot

k8s-ci-robot commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: d0616f9e17317de78a0943bc75132415150d30be

@k8s-ci-robot

k8s-ci-robot commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@liangyuanpeng liangyuanpeng mentioned this pull request Feb 29, 2024
Merged
@k8s-ci-robot k8s-ci-robot merged commit 3718932 into kubernetes:master Feb 29, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 29, 2024
This was referenced Dec 16, 2024
Merged
Merged
DamianSawicki added a commit to DamianSawicki/test-infra that referenced this pull request Dec 16, 2024
@DamianSawicki
Add presubmits for kubedns/nodelocaldns bumps
d52cb77 
This is to detect regressions before merging rather than by inspecting
the periodic test grid after merging. Such inssues happened at least twice
recently at kubernetes/kubernetes#123590 and
kubernetes/kubernetes#129230.

Signed-off-by: Damian Sawicki <dsawicki@google.com>
DamianSawicki added a commit to DamianSawicki/test-infra that referenced this pull request Dec 16, 2024
@DamianSawicki
Add presubmits for kubedns/nodelocaldns bumps
69f2ca1 
This is to detect regressions before merging rather than by inspecting
the periodic test grid after merging. Such inssues happened at least twice
recently at kubernetes/kubernetes#123590 and
kubernetes/kubernetes#129230.

Signed-off-by: Damian Sawicki <dsawicki@google.com>
DamianSawicki added a commit to DamianSawicki/test-infra that referenced this pull request Dec 16, 2024
@DamianSawicki
Add presubmits for kubedns/nodelocaldns bumps
1b47892 
This is to detect regressions before merging rather than by inspecting
the periodic test grid after merging. Such inssues happened at least twice
recently at kubernetes/kubernetes#123590 and
kubernetes/kubernetes#129230.

Signed-off-by: Damian Sawicki <dsawicki@google.com>
DamianSawicki added a commit to DamianSawicki/test-infra that referenced this pull request Dec 16, 2024
@DamianSawicki
Add presubmits for kubedns/nodelocaldns bumps
b80d112 
This is to detect regressions before merging rather than by inspecting
the periodic test grid after merging. Such inssues happened at least twice
recently at kubernetes/kubernetes#123590 and
kubernetes/kubernetes#129230.

Signed-off-by: Damian Sawicki <dsawicki@google.com>
hbostan pushed a commit to hbostan/test-infra that referenced this pull request Feb 5, 2025
@DamianSawicki @hbostan
Add presubmits for kubedns/nodelocaldns bumps
c268928 
This is to detect regressions before merging rather than by inspecting
the periodic test grid after merging. Such inssues happened at least twice
recently at kubernetes/kubernetes#123590 and
kubernetes/kubernetes#129230.

Signed-off-by: Damian Sawicki <dsawicki@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bzsuni bzsuni Awaiting requested review from bzsuni

@kl52752 kl52752 Awaiting requested review from kl52752

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@dims dims

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.30

Development

Successfully merging this pull request may close these issues.

3 participants

@aojea @k8s-ci-robot @dims