Skip to content

deflake TestUpdateNodeStatusWithLease test#128636

Closed
mengqiy wants to merge 1 commit into
kubernetes:masterfrom
mengqiy:spreadkubeletlaod
Closed

deflake TestUpdateNodeStatusWithLease test#128636
mengqiy wants to merge 1 commit into
kubernetes:masterfrom
mengqiy:spreadkubeletlaod

Conversation

@mengqiy

@mengqiy mengqiy commented Nov 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

What type of PR is this?

/kind failing-test
/kind flake

What this PR does / why we need it:

TestUpdateNodeStatusWithLease is not introduced by #128394.

TestUpdateNodeStatusWithLease is failing after we merge #128394 because in TestUpdateNodeStatusWithLease nodeStatusReportFrequency is set to 1m and the test expect an node status update to happen after 1m. But after #128394, this becomes 50%.

How I fix it in this PR is to nodeStatusReportFrequency to 30s so that we can expect an an node status update to happen due to time passage.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/flake Categorizes issue or PR as related to a flaky test. labels Nov 7, 2024
@k8s-ci-robot

k8s-ci-robot commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mengqiy
Once this PR has been reviewed and has the lgtm label, please assign yujuhong for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2024
@k8s-ci-robot

k8s-ci-robot commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 7, 2024
@mengqiy mengqiy mentioned this pull request Nov 7, 2024
Merged
@mengqiy

mengqiy commented Nov 7, 2024

Copy link
Copy Markdown
Member Author

/assign @SergeyKanzhelev

@mengqiy mengqiy closed this Nov 7, 2024
@mengqiy mengqiy deleted the spreadkubeletlaod branch November 7, 2024 04:13
@mengqiy

mengqiy commented Nov 7, 2024

Copy link
Copy Markdown
Member Author

This is superseded by #128640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobbypage bobbypage Awaiting requested review from bobbypage

@rphillips rphillips Awaiting requested review from rphillips

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels

area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

SIG Node CI/Test Board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mengqiy @k8s-ci-robot @SergeyKanzhelev