Skip to content

Revert "Add random interval to nodeStatusReport interval every time after an actual node status change#128629

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
liggitt:revert-spreadkubeletload
Nov 7, 2024
Merged

Revert "Add random interval to nodeStatusReport interval every time after an actual node status change#128629
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
liggitt:revert-spreadkubeletload

Conversation

@liggitt

@liggitt liggitt commented Nov 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This reverts commit d6e17ad.

Introduced unit test flakes, seen in https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/128190/pull-kubernetes-unit/1854263632594997248

When run with stress / race, that test fails 60% of runs locally

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@liggitt
Revert "Add random interval to nodeStatusReport interval every time a…
4850b31 
…fter an actual node status change"

This reverts commit d6e17ad.
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 6, 2024
@k8s-ci-robot

k8s-ci-robot commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 6, 2024
@liggitt liggitt mentioned this pull request Nov 6, 2024
Merged
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 6, 2024
@liggitt

liggitt commented Nov 6, 2024

Copy link
Copy Markdown
Member Author

/sig node
/kind flake
/priority important-soon
/assign @SergeyKanzhelev @mengqiy

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 6, 2024
@kannon92 kannon92 mentioned this pull request Nov 6, 2024
Merged
@dims

dims commented Nov 6, 2024

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2024
@k8s-ci-robot

k8s-ci-robot commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 7a4bbaab909f23f06e7fb1211f955361a6649636

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 6, 2024
@liggitt liggitt mentioned this pull request Nov 6, 2024
Merged
@liggitt liggitt added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 6, 2024
@SergeyKanzhelev

SergeyKanzhelev commented Nov 6, 2024

Copy link
Copy Markdown
Member

/approve

@mengqiy plaase re-send your PR with the fixed tests

@k8s-ci-robot

k8s-ci-robot commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aramase aramase mentioned this pull request Nov 7, 2024
Closed
@AnishShah

AnishShah commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

/retest

@mengqiy

mengqiy commented Nov 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Created #128636 to fix the flaky unit test: TestUpdateNodeStatusWithLease

@mengqiy

mengqiy commented Nov 7, 2024

Copy link
Copy Markdown
Member

It seems the tests in #128636 started a few minutes earlier than the e2e test rerun in this PR.
I wonder if it's easier to merge #128636 directly.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2024
@mengqiy

mengqiy commented Nov 7, 2024

Copy link
Copy Markdown
Member

@SergeyKanzhelev Can you please take a look at this one line PR: #128636

@mengqiy

mengqiy commented Nov 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

If #128636 don't have approved when the e2e test finishes in this PR, please feel free to remove hold and let this PR merge and unblock others.

I will monitor both PRs in the next few hours

@kannon92

kannon92 commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

/hold cancel

We usually avoid fixing forward a test. Since this was causing some flakes, it would be best to add back your PR with your one-line change.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2024
@mengqiy

mengqiy commented Nov 7, 2024

Copy link
Copy Markdown
Member

Fair enough! Thank you!

@liggitt liggitt mentioned this pull request Nov 7, 2024
Merged
@liggitt liggitt added this to the v1.32 milestone Nov 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3184eb3 into kubernetes:master Nov 7, 2024
@carlory carlory mentioned this pull request Nov 7, 2024
Merged
@yongruilin yongruilin mentioned this pull request Nov 7, 2024
Merged
@liggitt liggitt mentioned this pull request Nov 7, 2024
Merged
@mengqiy

mengqiy commented Nov 7, 2024

Copy link
Copy Markdown
Member

@mengqiy plaase re-send your PR with the fixed tests

Created #128640 to attempt this change again with fixed test.

@liggitt liggitt deleted the revert-spreadkubeletload branch December 13, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@dims dims

@mengqiy mengqiy

@SergeyKanzhelev SergeyKanzhelev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project
[sig-release] Bug Triage
Archived in project

Milestone

v1.32

Development

Successfully merging this pull request may close these issues.

8 participants

@liggitt @k8s-ci-robot @dims @SergeyKanzhelev @AnishShah @mengqiy @kannon92 @benjaminapetersen