Skip to content

Automated cherry pick of #127417: bugfix: endpoints controller track resource version#127452

Merged
k8s-ci-robot merged 2 commits into
kubernetes:release-1.30from
swetharepakula:automated-cherry-pick-of-#127417-origin-release-1.30
Sep 19, 2024
Merged

Automated cherry pick of #127417: bugfix: endpoints controller track resource version#127452
k8s-ci-robot merged 2 commits into
kubernetes:release-1.30from
swetharepakula:automated-cherry-pick-of-#127417-origin-release-1.30

Conversation

@swetharepakula

@swetharepakula swetharepakula commented Sep 18, 2024

Copy link
Copy Markdown
Member

Cherry pick of #127417 on release-1.30.

#127417: bugfix: endpoints controller track resource version

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 18, 2024
@k8s-ci-robot

k8s-ci-robot commented Sep 18, 2024

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 18, 2024
@aojea

aojea commented Sep 18, 2024

Copy link
Copy Markdown
Member

you need to adapt the backport integration test

ERROR(linux/s390x): /home/prow/go/src/k8s.io/kubernetes/test/integration/endpoints/endpoints_test.go:613:72: undefined: framework.DefaultTestServerFlags

check one of the other tests in the same file for guidance

This was referenced Sep 18, 2024
Merged
Merged
aojea and others added 2 commits September 18, 2024 11:09
@aojea @swetharepakula
define some default kube-apiserver flags for tests disabling unneded …
9844402 
…controllers
@M00nF1sh @swetharepakula
bugfix: endpoints controller track resource version conrrectly
47c8669 
The endpoints controller store the resource version of the previous
Endpoints objects to avoid issues related to stale information on the
cache.

However, there can be update operations that succeed without increasing
the resource version, causing the endpoints controller to declare stale
the existing Resource Version and stopping the Endpoints to be updated.

Co-Author-By: Quan Tian <quan.tian@broadcom.com>
Co-Author-By: Yang Yang <yyyng@amazon.com>
@swetharepakula swetharepakula force-pushed the automated-cherry-pick-of-#127417-origin-release-1.30 branch from 77f65a6 to 47c8669 Compare September 18, 2024 18:09
@aojea

aojea commented Sep 19, 2024

Copy link
Copy Markdown
Member

/lgtm
/approve
/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 19, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 19, 2024
@k8s-ci-robot

k8s-ci-robot commented Sep 19, 2024

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 58b8557a6d9525f26d1c0ef2943699279fa50e53

@k8s-ci-robot

k8s-ci-robot commented Sep 19, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2024
@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 19, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit f877211 into kubernetes:release-1.30 Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khenidak khenidak Awaiting requested review from khenidak

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@aojea aojea

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Apps
Archived in project

Milestone

v1.30

Development

Successfully merging this pull request may close these issues.

5 participants

@swetharepakula @k8s-ci-robot @aojea @Verolop @M00nF1sh