Skip to content

Update kubedns and nodelocaldns to v1.23.0#123310

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
bzsuni:update/dns/v1.23.0
Feb 28, 2024
Merged

Update kubedns and nodelocaldns to v1.23.0#123310
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
bzsuni:update/dns/v1.23.0

Conversation

@bzsuni

@bzsuni bzsuni commented Feb 15, 2024

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update kubedns and nodelocaldns to dns v1.23.0

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update kubedns and nodelocaldns to v1.23.0

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

none

@bzsuni
Update kubedns and nodelocaldns to v1.23.0
b5b62d4 
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 15, 2024
@k8s-ci-robot

k8s-ci-robot commented Feb 15, 2024

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 15, 2024
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 15, 2024
@bzsuni

bzsuni commented Feb 18, 2024

Copy link
Copy Markdown
Contributor Author

@MrHohn for review please

@ping035627

ping035627 commented Feb 18, 2024

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2024
@k8s-ci-robot

k8s-ci-robot commented Feb 18, 2024

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: b3f6fb9a603957e8743438171f64cf5eef652ad5

@MrHohn

MrHohn commented Feb 20, 2024

Copy link
Copy Markdown
Member

/assign @kl52752

@bzsuni

bzsuni commented Feb 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

for review and approval please @kl52752

@kl52752

kl52752 commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot

k8s-ci-robot commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bzsuni, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit 30a68e4 into kubernetes:master Feb 28, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 28, 2024
@aojea

aojea commented Feb 29, 2024

Copy link
Copy Markdown
Member

@bzsuni @kl52752 we have to promote the image before updating the manifests

gcr.io/k8s-staging-dns/k8s-dns-node-cache:1.23.0 exists, someone should run kpromo to get it promoted

ci is failing now https://testgrid.k8s.io/sig-network-gce#gci-gce-coredns-nodecache since this merged, I'm going to revert until the image is promoted

@aojea aojea mentioned this pull request Feb 29, 2024
Merged
@liangyuanpeng

liangyuanpeng commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

Let me try to open a PR to promote images of dns.

@liangyuanpeng liangyuanpeng mentioned this pull request Feb 29, 2024
Merged
@kl52752

kl52752 commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

thanks @aojea for handling this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kl52752 kl52752 Awaiting requested review from kl52752

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@ping035627 ping035627

@kl52752 kl52752

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.30

Development

Successfully merging this pull request may close these issues.

7 participants

@bzsuni @k8s-ci-robot @ping035627 @MrHohn @kl52752 @aojea @liangyuanpeng