Skip to content

update release-note for cherry-picks of #110255#113285

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
pacoxu:release-note-update
Dec 13, 2022
Merged

update release-note for cherry-picks of #110255#113285
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
pacoxu:release-note-update

Conversation

@pacoxu

@pacoxu pacoxu commented Oct 24, 2022

Copy link
Copy Markdown
Member

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 24, 2022
@k8s-ci-robot

k8s-ci-robot commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

@pacoxu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 24, 2022
@pacoxu

pacoxu commented Oct 24, 2022

Copy link
Copy Markdown
Member Author

/cc @mirobertod @aojea @robscott

@k8s-ci-robot

k8s-ci-robot commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

@pacoxu: GitHub didn't allow me to request PR reviews from the following users: mirobertod.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @mirobertod @aojea @robscott

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 24, 2022
@pacoxu

pacoxu commented Oct 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Not sure which is the correct way.

  1. this pr: fix the change log directly
  2. or add release-note to the cherry-picks: will the changelog of old patch releases be updated automatically?

@pacoxu

pacoxu commented Oct 31, 2022

Copy link
Copy Markdown
Member Author

/test pull-kubernetes-unit
for flake

@pacoxu

pacoxu commented Dec 13, 2022

Copy link
Copy Markdown
Member Author

@release-engineering-approvers

@cpanato

cpanato commented Dec 13, 2022

Copy link
Copy Markdown
Member

/assign @xmudrii @saschagrunert
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
xmudrii
xmudrii approved these changes Dec 13, 2022
View reviewed changes

@xmudrii xmudrii left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot

k8s-ci-robot commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@pacoxu

pacoxu commented Dec 13, 2022

Copy link
Copy Markdown
Member Author

/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot k8s-ci-robot merged commit 10376ad into kubernetes:master Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xmudrii xmudrii xmudrii approved these changes

@aojea aojea Awaiting requested review from aojea

@robscott robscott Awaiting requested review from robscott

@cpanato cpanato Awaiting requested review from cpanato

@harshanarayana harshanarayana Awaiting requested review from harshanarayana

Assignees

@saschagrunert saschagrunert

@cpanato cpanato

@xmudrii xmudrii

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.27

Development

Successfully merging this pull request may close these issues.

5 participants

@pacoxu @k8s-ci-robot @cpanato @xmudrii @saschagrunert