Skip to content

Automated cherry pick of #110255: Endpoints and EndpointSlices should not publish IPs for terminal pods#110258

Merged
k8s-ci-robot merged 6 commits into
kubernetes:release-1.24from
robscott:automated-cherry-pick-of-#110255-upstream-release-1.24
Jun 3, 2022
Merged

Automated cherry pick of #110255: Endpoints and EndpointSlices should not publish IPs for terminal pods#110258
k8s-ci-robot merged 6 commits into
kubernetes:release-1.24from
robscott:automated-cherry-pick-of-#110255-upstream-release-1.24

Conversation

@robscott

@robscott robscott commented May 27, 2022

Copy link
Copy Markdown
Member

Cherry pick of #110255 on release-1.24.

#110255: add pod util to verify pod is terminal

For details on the cherry pick process, see the cherry pick requests page.

aojea and others added 6 commits May 27, 2022 23:28
@aojea @robscott
add pod util to verify pod is terminal
3bbb91b 
pods on phase succeeded or failed are guaranteed to have all containers
stopped and to not ever regress
@aojea @robscott
endpointslices: terminal pods doesn't receive enpoints
767e6a0
@aojea @robscott
endpoints controller: don't consider terminal endpoints
dba5200 
Terminal pods, whose phase its Failed or Succeeded, are guaranteed
to never regress and to be stopped, so their IPs never should
be published on the Endpoints.
@aojea @robscott
e2e test for evicted pods
bcde4ea
@aojea @robscott
e2e: services with evicted pods doesn't have endpoints
7e65c7c
@robscott
Updating e2e test to check EndpointSlices and Endpoints as well
68e8b66
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone May 27, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels May 27, 2022
@k8s-ci-robot k8s-ci-robot requested review from aojea and bowei May 27, 2022 23:30
@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 27, 2022
@robscott

robscott commented May 27, 2022

Copy link
Copy Markdown
Member Author

/sig network
/priority important-soon
/triage accepted
/cc @aojea @bowei @swetharepakula
/assign @thockin

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 27, 2022
@k8s-ci-robot k8s-ci-robot removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 27, 2022
@thockin thockin changed the title Automated cherry pick of #110255: add pod util to verify pod is terminal Automated cherry pick of #110255: Endpoints and EndpointSlices should not publish IPs for terminal pods May 28, 2022
@thockin

thockin commented May 28, 2022

Copy link
Copy Markdown
Member

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2022
@k8s-ci-robot

k8s-ci-robot commented May 28, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2022
@robscott

robscott commented May 28, 2022

Copy link
Copy Markdown
Member Author

cc @kubernetes/release-managers

@jluhrsen

jluhrsen commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 2, 2022
@jluhrsen jluhrsen mentioned this pull request Jun 2, 2022
Closed
@puerco

puerco commented Jun 3, 2022

Copy link
Copy Markdown
Member

Thanks @robscott !
/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 3, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit a6b031e into kubernetes:release-1.24 Jun 3, 2022
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 3, 2022
Merged
This was referenced Oct 24, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aojea aojea Awaiting requested review from aojea

@bowei bowei Awaiting requested review from bowei

@swetharepakula swetharepakula Awaiting requested review from swetharepakula

Assignees

@puerco puerco

@thockin thockin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project

Milestone

v1.24

Development

Successfully merging this pull request may close these issues.

7 participants

@robscott @thockin @k8s-ci-robot @jluhrsen @puerco @SergeyKanzhelev @aojea