Skip to content

Validate LabelSelector for TopologySpreadConstraints#112121

Closed
chendave wants to merge 1 commit intokubernetes:masterfrom
chendave:validate_ls
Closed

Validate LabelSelector for TopologySpreadConstraints#112121
chendave wants to merge 1 commit intokubernetes:masterfrom
chendave:validate_ls

Conversation

@chendave
Copy link
Copy Markdown
Member

@chendave chendave commented Aug 30, 2022 •
edited
Loading

/kind cleanup

Signed-off-by: Dave Chen dave.chen@arm.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

address the comments here: https://github.com/kubernetes/kubernetes/pull/111441/files#r933399816

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@chendave
Validate LabelSelector for TopologySpreadConstraints
5480529 
Signed-off-by: Dave Chen <dave.chen@arm.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 30, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 30, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chendave
Once this PR has been reviewed and has the lgtm label, please assign smarterclayton for approval by writing /assign @smarterclayton in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 30, 2022
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 30, 2022
@chendave chendave mentioned this pull request Aug 30, 2022
Merged
@chendave
Copy link
Copy Markdown
Member Author

chendave commented Aug 30, 2022 •
edited
Loading

/assign @liggitt I am trying to reuse some existing method for the validation, pls take a look, thanks!

@chendave
Copy link
Copy Markdown
Member Author

chendave commented Aug 30, 2022

/assign @liggitt

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Aug 30, 2022

thanks for the PR, I think this is already in progress in #111802

@leilajal
Copy link
Copy Markdown
Contributor

leilajal commented Aug 30, 2022

/assign @cici37
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 30, 2022
@chendave
Copy link
Copy Markdown
Member Author

chendave commented Aug 31, 2022

/close

in favor of #111802

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 31, 2022

@chendave: Closed this PR.

Details

In response to this:

/close

in favor of #111802

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@logicalhan logicalhan Awaiting requested review from logicalhan

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@liggitt liggitt

@cici37 cici37

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chendave @k8s-ci-robot @liggitt @leilajal @cici37