Add proper integration test suite#1009
Conversation
|
@brendandburns @lavalamp review please - in this model all integration tests would go into subdirectories of |
bade1c1 to
8b490c7
Compare
|
LGTM ./integration or ./test/integration ? e.g. when we have more classes of tests that are bigger than units, where will they live? |
|
Test makes sense, will move it under there. |
8b490c7 to
b037989
Compare
|
Fixed |
|
LGTM stands. Who is number 2? |
There was a problem hiding this comment.
Shouldn't we call SetObj(key, "object") again to cover the CompareAndSwap case in SetObj method?
It seems there are a lot more such cases, but most of them is covered in unittest. Can we assume they work as expected?
There was a problem hiding this comment.
Probably we want to test main scenarios, of which CAS is a big one. Once this lands I think we'll start asking folks to make sure they have integration test coverage for their high value paths.
|
LGTM as long as this still runs our current integration test, does it? |
|
Yup. |
Add proper integration test suite
add unit test for 'validate' package
…ated_pods_openshift_4.9 [release-4.9] Bug 2011815: UPSTREAM: 105527: kubelet: do not arbitrarily create a podSyncStatus for finished pods
Only tests etcd, but sets framework for other types of tests. Runs as part of hack/test-integration.sh during Travis. Use the !no-docker tag for test suites that include Docker specific behavior.
Fixes #510