Skip to content

kubelet cgroup-root should be / for k8s 1.6#1944

Closed
derekwaynecarr wants to merge 1 commit into
kubernetes:masterfrom
derekwaynecarr:cgroup-root-fix
Closed

kubelet cgroup-root should be / for k8s 1.6#1944
derekwaynecarr wants to merge 1 commit into
kubernetes:masterfrom
derekwaynecarr:cgroup-root-fix

Conversation

@derekwaynecarr

@derekwaynecarr derekwaynecarr commented Feb 18, 2017

Copy link
Copy Markdown
Member

sig-node is deploying a new cgroup hierarchy to support per pod cgroups and enforcement of node alloctable. to support that, the pods should not be a children of the container runtime.

see: kubernetes/kubernetes#41349


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 18, 2017
@derekwaynecarr

Copy link
Copy Markdown
Member Author

a follow-on is also needed to enable memcg and cpu accounting by default on whatever OS images this is deploying against...

@derekwaynecarr

Copy link
Copy Markdown
Member Author

@justinsb -- could you assist in ensuring that cpu and memcg accounting is enabled globally on the aws e2e environment?

@derekwaynecarr

Copy link
Copy Markdown
Member Author

Poke ? This has some urgency for items to merge in time for feature freeze.

@geojaz geojaz requested a review from justinsb February 21, 2017 01:39
@justinsb

Copy link
Copy Markdown
Member

@derekwaynecarr can you confirm the kubelet flag settings for 1.6 should be:

cgroup-root = "/"
runtime-cgroups unset
kubelet-cgroups unset
system-cgroups unset

If so I think the way to do this is to only apply these settings for k8s 1.6 and up, as the k8s 1.5 (and lower) settings appear to be as kops has them.

@justinsb

Copy link
Copy Markdown
Member

(I can send a simple PR for you to review as that may be more expedient!)

@justinsb justinsb closed this Feb 21, 2017
@justinsb justinsb reopened this Feb 21, 2017
@derekwaynecarr

Copy link
Copy Markdown
Member Author

@justinsb -- what you described for 1.6 is adequate. can you prioritize getting a PR today?

@yissachar

Copy link
Copy Markdown
Contributor

@derekwaynecarr We've merged #1955, so this should be obsolete now. Thanks for the PR!

@yissachar yissachar closed this Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants