Update cgroup hierarchies for k8s 1.6#1955
Merged
yissachar merged 1 commit intoFeb 21, 2017
Merged
Conversation
We're going with a much cleaner cgroup hierarchy for k8s 1.6
Member
Author
|
cc @derekwaynecarr ... this is your work, but wrapped in a version check so we don't change the configuration of existing clusters until 1.6. Testing this on ubuntu now as that was the problematic OS IIRC. I wrote this on the other PR also, but can you confirm the kubelet flag settings for 1.6 should be the following (at least for now!): |
justinsb
commented
Feb 21, 2017
| clusterSpec.Kubelet.RuntimeCgroups = "/docker-daemon" | ||
| clusterSpec.Kubelet.KubeletCgroups = "/kubelet" | ||
| clusterSpec.Kubelet.SystemCgroups = "/system" | ||
| clusterSpec.Kubelet.CgroupRoot = "/" |
Member
Author
There was a problem hiding this comment.
We haven't shipped GCE support in kops quite yet, so we don't need to worry about back-compat here.
Member
|
this is LGTM, can we get this merged asap? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're going with a much cleaner cgroup hierarchy for k8s 1.6
This change is