Skip to content

aws: Allow warm pool with mixed instances policy#17800

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
kimxogus:feature/warmpool-for-mixed-instance-policy
Dec 9, 2025
Merged

aws: Allow warm pool with mixed instances policy#17800
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
kimxogus:feature/warmpool-for-mixed-instance-policy

Conversation

@kimxogus
Copy link
Copy Markdown
Contributor

@kimxogus kimxogus commented Dec 9, 2025

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 9, 2025

Hi @kimxogus. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab December 9, 2025 04:49
@hakman
Copy link
Copy Markdown
Member

hakman commented Dec 9, 2025

Hi @kimxogus, did you build the kops binary and tried this?

@kimxogus
Copy link
Copy Markdown
Contributor Author

kimxogus commented Dec 9, 2025

Hi, @hakman. Yes, I've built and tested with this pr.

@hakman
Copy link
Copy Markdown
Member

hakman commented Dec 9, 2025

Thank you for confirming, and thank you for your contribution!
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2025
@hakman hakman changed the title feat: Allow warm pool with mixed instances policy aws: Allow warm pool with mixed instances policy Dec 9, 2025
@hakman
Copy link
Copy Markdown
Member

hakman commented Dec 9, 2025

/override pull-kops-e2e-k8s-gce-ipalias
/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 9, 2025

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-ipalias

Details

In response to this:

/override pull-kops-e2e-k8s-gce-ipalias
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6125e12 into kubernetes:master Dec 9, 2025
35 of 38 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Dec 9, 2025
@kimxogus kimxogus deleted the feature/warmpool-for-mixed-instance-policy branch December 9, 2025 13:58
@kimxogus
Copy link
Copy Markdown
Contributor Author

kimxogus commented Dec 9, 2025

@hakman Thanks for quick review and merge 👍
Is this pr going to be cherry-picked to 1.34?

@hakman
Copy link
Copy Markdown
Member

hakman commented Dec 9, 2025

@kimxogus If it help, sure 1.34 is ok. Could you create the cherry-pick PR using this script?
https://github.com/kubernetes/kubernetes/blob/master/hack/cherry_pick_pull.sh

@kimxogus kimxogus mentioned this pull request Dec 10, 2025
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2025
@k8s-ci-robot
Merge pull request #17803 from kimxogus/automated-cherry-pick-of-#178…
ed96bb9 
…00-upstream-release-1.34

Automated cherry pick of #17800: aws: Allow warm pool with mixed instances policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman Awaiting requested review from hakman

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

Support WarmPool for mixed instance policy

3 participants

@kimxogus @k8s-ci-robot @hakman