Skip to content

aws: Disable the kubelet systemd unit during warm pool warming#17792

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
dezmodue:warmPoolNoKubelet
Dec 9, 2025
Merged

aws: Disable the kubelet systemd unit during warm pool warming#17792
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
dezmodue:warmPoolNoKubelet

Conversation

@dezmodue
Copy link
Copy Markdown
Contributor

@dezmodue dezmodue commented Dec 5, 2025

As discussed yesterday during the kOps meeting - this patch makes sure that the kubelet systemd unit is not enabled by nodeup during the warming phase. This helps for use cases where a reboot is needed during the warming up phase and systemd would start the kubelet after reboot causing the node to join the cluster before the warming lifecycle is completed.

Ping @justinsb as requested

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 5, 2025

Hi @dezmodue. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested a review from zetaab December 5, 2025 13:57
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 5, 2025
@hakman
Copy link
Copy Markdown
Member

hakman commented Dec 5, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 5, 2025
@hakman hakman changed the title WIP - Nodeup: do not enable the kubelet systemd unit during Warming lifecycle (warm pool) WIP - aws: Disable the kubelet systemd unit during warm pool warming Dec 5, 2025
@hakman
Copy link
Copy Markdown
Member

hakman commented Dec 8, 2025

/test pull-kops-e2e-cni-amazonvpc
/test pull-kops-e2e-k8s-aws-amazonvpc

@hakman
Copy link
Copy Markdown
Member

hakman commented Dec 8, 2025

@dezmodue did you get a chance to test this on a test cluster with your setup?

@dezmodue
Copy link
Copy Markdown
Contributor Author

dezmodue commented Dec 8, 2025

@hakman we are about to test it - I will report back

@hakman
Copy link
Copy Markdown
Member

hakman commented Dec 8, 2025

@hakman we are about to test it - I will report back

If you want to use the build from this PR, you can look into the build log for KOPS_BASE_URL.
You just need to build the kops binary and export KOPS_BASE_URL=....
Clusters will be created with the binaries from KOPS_BASE_URL.

@hakman
Copy link
Copy Markdown
Member

hakman commented Dec 8, 2025

/retest

@dezmodue
Copy link
Copy Markdown
Contributor Author

dezmodue commented Dec 9, 2025 •
edited
Loading

@hakman we have tested this change on v1.32.2 of kops - we have currently no quick way to test on a more recent version.
It works as expected - nodeup does not enable kubelet during the run and therefore the node does not join the cluster prematurely. Once the instance is brought into service the kubelet is started and the node joins the cluster correctly.

@hakman
Copy link
Copy Markdown
Member

hakman commented Dec 9, 2025

Sounds good. Feel free to remove WIP when ready.

@dezmodue dezmodue changed the title WIP - aws: Disable the kubelet systemd unit during warm pool warming aws: Disable the kubelet systemd unit during warm pool warming Dec 9, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2025
@hakman
Copy link
Copy Markdown
Member

hakman commented Dec 9, 2025

Thanks @dezmodue!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 38efd7a into kubernetes:master Dec 9, 2025
27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Dec 9, 2025
This was referenced Dec 9, 2025
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2025
@k8s-ci-robot
Merge pull request #17801 from dezmodue/automated-cherry-pick-of-#177…
5e546d9 
…92-upstream-release-1.34

Automated cherry pick of #17792: aws: Disable the kubelet systemd unit during warm pool warming
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2025
@k8s-ci-robot
Merge pull request #17802 from dezmodue/automated-cherry-pick-of-#177…
6683c42 
…92-upstream-release-1.33

Automated cherry pick of #17792: aws: Disable the kubelet systemd unit during warm pool warming
This was referenced Dec 10, 2025
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 11, 2025
@k8s-ci-robot
Merge pull request #17807 from dezmodue/automated-cherry-pick-of-#177…
99fc697 
…92-upstream-release-1.32

Automated cherry pick of #17792: aws: Disable the kubelet systemd unit during warm pool warming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

3 participants

@dezmodue @k8s-ci-robot @hakman