Skip to content

aws: Enable CloudWatch metrics for the warm pool of an ASG#17776

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
recollir:warmpool-metrics
Nov 28, 2025
Merged

aws: Enable CloudWatch metrics for the warm pool of an ASG#17776
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
recollir:warmpool-metrics

Conversation

@recollir
Copy link
Copy Markdown
Contributor

@recollir recollir commented Nov 28, 2025

Fixes #17775 by conditionally enabling CloudWatch metrics for the warm pool of an ASG (if used and enabled). hack/update-expected.sh was run and resulted in a change of tests/integration/update_cluster/minimal-warmpool

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 28, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 28, 2025

Hi @recollir. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/provider/aws Issues or PRs related to aws provider labels Nov 28, 2025
@recollir
Copy link
Copy Markdown
Contributor Author

recollir commented Nov 28, 2025

Ping @hakman

@hakman hakman changed the title AWS: Enable CloudWatch metrics for the warm pool of an ASG aws: Enable CloudWatch metrics for the warm pool of an ASG Nov 28, 2025
@hakman
Copy link
Copy Markdown
Member

hakman commented Nov 28, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 28, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2025
@hakman
Copy link
Copy Markdown
Member

hakman commented Nov 28, 2025

/override pull-kops-e2e-k8s-gce-cilium

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 28, 2025

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-cilium

Details

In response to this:

/override pull-kops-e2e-k8s-gce-cilium

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 3b18538 into kubernetes:master Nov 28, 2025
27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Nov 28, 2025
This was referenced Nov 28, 2025
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 28, 2025
@k8s-ci-robot
Merge pull request #17778 from recollir/automated-cherry-pick-of-#177…
ccf0f3a 
…76-upstream-release-1.34

Automated cherry pick of #17776: aws: Enable CloudWatch metrics for the warm pool of an ASG
k8s-ci-robot added a commit that referenced this pull request Nov 28, 2025
@k8s-ci-robot
Merge pull request #17779 from recollir/automated-cherry-pick-of-#177…
b58d19a 
…76-upstream-release-1.33

Automated cherry pick of #17776: aws: Enable CloudWatch metrics for the warm pool of an ASG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@hakman hakman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

AWS: CloudWatch metrics for a warm pool of an ASG are not enabled

3 participants

@recollir @k8s-ci-robot @hakman