fix: resolve env_file variable interpolation issues by adding support…#2011
fix: resolve env_file variable interpolation issues by adding support…#2011k8s-ci-robot merged 2 commits intokubernetes:mainfrom
Conversation
… for and default syntax
|
/assign @cdrage |
|
/cc @cdrage |
|
Hi @cdrage , thanks for your time! |
cdrage
left a comment
There was a problem hiding this comment.
Love it! I honestly see no problems with this and the code is wonderful.
Great job and LGTM! :) I'm going to approve and if all the tests pass, it'll merge.
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, yuefanxiao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Looks like one small test is failing |
Apologies for the test failure - I should have caught this during implementation. I'll investigate the issue immediately and provide a fix as soon as possible. Thank you for flagging this, and I'll update you once resolved. |
|
Woooo 🚀 awesome work! /lgtm |
… for and default syntax
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2010
Special notes for your reviewer: