Skip to content

fix: Load variables from .env file by default#2008

Merged
k8s-ci-robot merged 2 commits intokubernetes:mainfrom
yuefanxiao:fix
May 14, 2025
Merged

fix: Load variables from .env file by default#2008
k8s-ci-robot merged 2 commits intokubernetes:mainfrom
yuefanxiao:fix

Conversation

@yuefanxiao
Copy link
Copy Markdown
Contributor

@yuefanxiao yuefanxiao commented Apr 27, 2025 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2006

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2025
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Apr 27, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 27, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 27, 2025

Welcome @yuefanxiao!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested review from TessaIO and cdrage April 27, 2025 10:12
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 27, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 27, 2025

@yuefanxiao: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yuefanxiao yuefanxiao marked this pull request as ready for review April 27, 2025 10:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 27, 2025
@yuefanxiao
Copy link
Copy Markdown
Contributor Author

yuefanxiao commented May 3, 2025

/cc @cdrage

@yuefanxiao
Copy link
Copy Markdown
Contributor Author

yuefanxiao commented May 3, 2025

/assign @cdrage

@cdrage
Copy link
Copy Markdown
Member

cdrage commented May 3, 2025

Thank you! Sorry for the slow reply. I'll have a look at reviewing this on Monday. I've gone ahead and approved the workflow so at least tests run.

@yuefanxiao
Copy link
Copy Markdown
Contributor Author

yuefanxiao commented May 13, 2025

Thank you! Sorry for the slow reply. I'll have a look at reviewing this on Monday. I've gone ahead and approved the workflow so at least tests run.

Hi @cdrage , thanks for your time!
Could you please take a look at this PR when you have a moment? I’d appreciate any feedback.

cdrage
cdrage requested changes May 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is good and I'm glad it's loading the variables by default..

However, any chance you're able to add a small test?

I know our testing suite isn't that great, but if you can add one with a .env file in the same folder and test it out / see if it works, that'd be awesome :)

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2025
@yuefanxiao
Copy link
Copy Markdown
Contributor Author

yuefanxiao commented May 14, 2025

So this is good and I'm glad it's loading the variables by default..

However, any chance you're able to add a small test?

I know our testing suite isn't that great, but if you can add one with a .env file in the same folder and test it out / see if it works, that'd be awesome :)

Thank you for the suggestion! I'll be happy to add a small test with a .env file to verify the variable loading functionality. I'll implement this as soon as possible and keep you updated on the progress. Appreciate your feedback!

@yuefanxiao yuefanxiao requested a review from cdrage May 14, 2025 15:26
cdrage
cdrage approved these changes May 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@cdrage cdrage left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

Thanks for the great changes.

I'll actually be doing a release shortly (most likely in the next hour), so you should see your work in the next version :)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, yuefanxiao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
@cdrage
Copy link
Copy Markdown
Member

cdrage commented May 14, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 416e8ea into kubernetes:main May 14, 2025
10 checks passed
@BrewTestBot BrewTestBot mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdrage cdrage cdrage approved these changes

@TessaIO TessaIO Awaiting requested review from TessaIO

Assignees

@cdrage cdrage

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Environment variables referencing .env values are resolved as blank in generated manifests

3 participants

@yuefanxiao @k8s-ci-robot @cdrage