Adds ability to specify the stage/target of a multistage dockerfile#1841
Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom Mar 21, 2024
Merged
Adds ability to specify the stage/target of a multistage dockerfile#1841k8s-ci-robot merged 1 commit intokubernetes:mainfrom
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
Conversation
Signed-off-by: jose luis <2064537+sosan@users.noreply.github.com>
TessaIO
approved these changes
Mar 16, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, sosan, TessaIO The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
sosan
pushed a commit
to sosan/kompose
that referenced
this pull request
Mar 23, 2024
Adds ability to specify the stage/target of a multistage dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Adds the ability to specify the stage/target of a multistage build from dockerfile
Which issue(s) this PR fixes:
Fixes #1839
Special notes for your reviewer:
maybe too much parameters?
buildDockerClient(source string, image string, dockerfile string, buildargs []dockerlib.BuildArg, outputBuffer *bytes.Buffer, buildTarget string)