Skip to content

Upgrade Kubernetes module to the latest version v0.27.3#1677

Merged
AhmedGrati merged 1 commit intokubernetes:mainfrom
payamQorbanpour:fix-upgrade-kubernetes-module
Jul 19, 2023
Merged

Upgrade Kubernetes module to the latest version v0.27.3#1677
AhmedGrati merged 1 commit intokubernetes:mainfrom
payamQorbanpour:fix-upgrade-kubernetes-module

Conversation

@payamQorbanpour
Copy link
Copy Markdown
Contributor

@payamQorbanpour payamQorbanpour commented Jul 19, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

In the previous version of the Kubernetes module, v022.5, an outdated struct named "Handler" was used in lines 289, 295, and 302. Upgrading the Kubernetes module to the latest version, v0.27.3, and updating the struct name to "ProbeHandler" should fix the problem.

Which issue(s) this PR fixes:

Fixes #1676

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 19, 2023
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Jul 19, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: payamQorbanpour (74947c7)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 19, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 19, 2023

Welcome @payamQorbanpour!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested review from cdrage and sebgoa July 19, 2023 15:51
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 19, 2023
@cdrage
Copy link
Copy Markdown
Member

cdrage commented Jul 19, 2023

@payamQorbanpour thank you! :)

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
AhmedGrati
AhmedGrati approved these changes Jul 19, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@AhmedGrati AhmedGrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @payamQorbanpour.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati, cdrage, payamQorbanpour

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AhmedGrati AhmedGrati merged commit 554a0ea into kubernetes:main Jul 19, 2023
@Lctrs Lctrs mentioned this pull request Aug 6, 2023
Merged
AhmedGrati pushed a commit that referenced this pull request Aug 23, 2023
@Lctrs
fix(dependabot): remove obsolete ignore list for go packages (#1685)
e9c6ecc 
Follow #1677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdrage cdrage cdrage approved these changes

@sebgoa sebgoa Awaiting requested review from sebgoa

+1 more reviewer

@AhmedGrati AhmedGrati AhmedGrati approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade Kubernetes module to the latest version v0.27.3

4 participants

@payamQorbanpour @k8s-ci-robot @cdrage @AhmedGrati