Works for me! Thank you :)

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati, cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

@AhmedGrati @cdrage Hi, Is there a way to disable this feature ? Or when there is no namespace specified it doesn't add all resources to default namespace. I use kompose with helm chart generation, and the namespace is decided on helm release installation.

The lines to be modified would be.

https://github.com/AhmedGrati/kompose/blob/608f87669f63a93c7af5700ee3d17bdbbf197256/pkg/transformer/utils.go#L465-L468

I can make a PR if needed.

This is a breaking change. We currently create a namespace with other resources in it before installing the chart generated by kompose (and overriding the namespace using helm's flags). This flow is no longer possible: if we don't set a namespace, everything goes into default. If we do set a namespace, the chart is no longer installable (since the namespace already exists and we don't want the chart to create it).

This is a breaking change. We currently create a namespace with other resources in it before installing the chart generated by kompose (and overriding the namespace using helm's flags). This flow is no longer possible: if we don't set a namespace, everything goes into default. If we do set a namespace, the chart is no longer installable (since the namespace already exists and we don't want the chart to create it).

On it! This shouldn't of been added, sorry about that. I totally missed it.

@github-belhorma-bendebiche Fixed in #1731

Thank you for the quick fix!